Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed '[WARNING] There were 0 download errors - check the warnings above to not log warning unless download errors > 0 #402

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Fixed '[WARNING] There were 0 download errors - check the warnings above to not log warning unless download errors > 0 #402

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a27a75
Fixed '[WARNING] There were 0 download errors - check the warnings ab…
Mar 18, 2021
9994a09
Fixed spelling error "supressing" -> "suppressing"
Mar 18, 2021
f2229f7
fix crlf
slawekjaranowski Jun 23, 2023
c2f46b5
Merge remote-tracking branch 'origin/master' into pr-402
slawekjaranowski Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions src/main/java/org/codehaus/mojo/license/AbstractDownloadLicensesMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,25 +822,20 @@ public void execute()
throw new MojoExecutionException( "Unable to write license summary file: " + licensesOutputFile, e );
}

switch ( errorRemedy )
{
case ignore:
case failFast:
/* do nothing */
break;
case warn:
LOG.warn( "There were {} download errors - check the warnings above", downloadErrorCount );
break;
case xmlOutput:
if ( downloadErrorCount > 0 )
{
throw new MojoFailureException( "There were " + downloadErrorCount + " download errors - check "
+ licensesErrorsFile.getAbsolutePath() );
}
break;
default:
throw new IllegalStateException( "Unexpected value of " + ErrorRemedy.class.getName() + ": "
+ errorRemedy );
if ( downloadErrorCount > 0 ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check formatting

switch (errorRemedy) {
case ignore:
case failFast:
/* do nothing */
break;
case warn:
LOG.warn("There were {} download errors - check the warnings above", downloadErrorCount);
break;
case xmlOutput:
throw new MojoFailureException("There were " + downloadErrorCount + " download errors - check " + licensesErrorsFile.getAbsolutePath());
default:
throw new IllegalStateException("Unexpected value of " + ErrorRemedy.class.getName() + ": " + errorRemedy);
}
}
}

Expand Down Expand Up @@ -1349,7 +1344,7 @@ private void handleError( ProjectLicenseInfo depProject, String msg ) throws Moj
{
if ( depProject.isApproved() )
{
LOG.debug( "Supressing manually approved license issue: {}", msg );
LOG.debug( "Suppressing manually approved license issue: {}", msg );
}
else
{
Expand Down