-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #139 - "Can't find license-maven-plugin" #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Besides the single inline comment, please add some simple integration test under src/it
.
src/main/java/org/codehaus/mojo/license/AggregatorAddThirdPartyMojo.java
Show resolved
Hide resolved
OK, now I see there is 0374cf4 that delivers the test coverage. |
Hmm, not that simple it seems, without digging in, is there a step thad does magic on the invoker.properties? |
That does it - no more build dep required for a command line - I'd not remove the legacy code in this request, but I'd agree it should be removed through new request/issue. |
The CI jobs are actually passing, but need an update to go green. |
I do not see the CI passing. I restarted Appveyor on Java 8 and I am investigating how to fix the broken Java installation in TravisCI. |
The master is now passing the whole OS x Java version matrix. Could you please rebase and also squash into a single commit? |
Use the PluginDescriptor. Most painful checkstyle. Update IT test to use no build dep and full coordinates Use project coordinates
The CI is flaky |
Yeah, the timeouts on Appveyor do not look good. |
I cleaned the caches on TravisCI and restarted. Let's see if it helps. |
Maven Central timeouts seems to be the cause of the random failures on the CI. AppVeyor passed for this PR, TravisCI passed here: #350 |
Use the PluginDescriptor.
Most painful checkstyle.