Bugfix/213 use relative links #215
Conversation
| @@ -0,0 +1,11 @@ | |||
| *.cmd text eol=crlf | |||
There was a problem hiding this comment.
Could you please explain what problem is this .gitattributes file trying to solve? In other words, what EOLs do you get now while there are no .gitattributes?
There was a problem hiding this comment.
Without this config, Git will checkout all files with the platform line ending (CRLF on Windows).
Also, the mvnw.cmd batch script was committed with Unix line endings (LF). WIth this file, the line endings of .cmd files will be correct on Linux as well.
Over the years, I've tried many approaches to fix line endings in projects and that's the best solution I've found so far.
There was a problem hiding this comment.
I do not think this is the default git behavior. Do you happen to have core.autocrlf true somewhere in your git config? You can check that via git config --list --show-origin. In case you do have core.autocrlf true for whatever reason, then you could override it to false for the current project by running git config --local core.autocrlf false in the current project directory.
I must say I prefer not adding a file that that will have to be kept in sync with .editorconfig. I prefer .editorconfig to be the single source of truth for line endings.
|
I don't want to proceed until we have agreed on a solution. Since I can't build the project without the git config fix, can I put that into the fix for #73? #215 depends on #73 for me, so same situation. I really don't understand why you can run the IT tests using |
…report Cherry-picked and reworded from mojohaus#215 by @digulla
third-party-report.html Cherry-picked and reworded from mojohaus#215 by @digulla
PR to fix issue #213
There are three commits:
One fixes the Git configuration to make sure all files are checked out with correct line endings on any OS. Note: Some old versions of JGit in Eclipse ignore this file.
Another fixes issue Class not found on mvn license:aggregate-third-party-report #73 (ClassNotFound exceptions when running reports). I'm not sure why I need this when using mvnw. I was under the impression that mvnw used it's own version/copy of Maven, no matter what is installed on the computer it runs on. All the other ITs are running, so why is this one failing?
The last commit finally fixes Links in aggregate-third-party-report.html point to third-party-report.html #213