Added a property name to the "sources" parameter for CLI usage #157
Conversation
|
@slachiewicz @stefanseifert Would one of you mind reviewing this pull request and associated issue and merge it if it looks like a good change? I apologize in advance if there's a contributor's guide that I'm not following. I looked and didn't see any instructions for getting a proposed change vetted and merged. Thank you and have a great day! |
|
@dantran @khmarbaise Would one of you mind reviewing this pull request and associated issue and then merge it if it looks good? Thanks in advance! |
|
@slachiewicz Hello. Would you mind reviewing and merging this one? It is a pretty simple change. Thanks in advance! |
|
@slawekjaranowski Would you mind reviewing and merging this one? It is a pretty simple change. Thanks in advance! Alternatively, if you're short on active participants that are able to review issues and pull requests you could add me as a maintainer. |
|
New sources should be added by configuration in pom, it can depends on previous executed goal ... We have also goals like add-test-source, add-resource, add-test-resource.... maybe those should also have a property ... but ok can be next time |
|
@slawekjaranowski Thank you for looking at this one. I agree that we may later want to add properties for other goals and that there's no need to include those changes here. Is there anything that you need from me at this time? |
See issue #156.
This command demonstrate this change in action:
mvn dependency:tree -DoutputFile=target/sonar-scan-reports/maven-dependency-tree.txt org.codehaus.mojo:build-helper-maven-plugin:3.4.0-SNAPSHOT:add-source -Dsources="./target/sonar-scan-reports/,./target/someOtherDir/"As described in the issue the idea here is to enable the user to generate files for each of the project's Maven modules and teach Maven where to find those files. This way when a plugin that runs later (ie: Sonarqube's scanner) executes Maven will provide it with the locations of these additional source files.