Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking test code is disabled by default #143

Merged
merged 2 commits into from
Feb 9, 2021
Merged

checking test code is disabled by default #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6456a21
checking test code is disabled by default
jtnord Feb 3, 2021
fa48d53
fix the mojo and IT
jtnord Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rcer-rule/src/main/java/org/codehaus/mojo/animal_sniffer/enforcer/CheckSignatureRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@ public class CheckSignatureRule
/**
* Should test classes be checked.
*
* //parameter default-value="true"
* //parameter default-value="false"
* @since 1.19
*/
private boolean checkTestClasses = true;
private boolean checkTestClasses = false;

public void execute( EnforcerRuleHelper helper )
throws EnforcerRuleException
Expand Down
4 changes: 2 additions & 2 deletions animal-sniffer-maven-plugin/src/it/github-5-test-classes/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
#
invoker.goals.1=verify -Danimal.sniffer.checkTestClasses=false
invoker.goals.1=verify

invoker.goals.2=verify
invoker.goals.2=verify -Danimal.sniffer.checkTestClasses=true
invoker.buildResult.2=failure
2 changes: 1 addition & 1 deletion ...maven-plugin/src/main/java/org/codehaus/mojo/animal_sniffer/maven/CheckSignatureMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public class CheckSignatureMojo
*
* @since 1.19
*/
@Parameter( property = "animal.sniffer.checkTestClasses", defaultValue = "true" )
@Parameter( property = "animal.sniffer.checkTestClasses", defaultValue = "false" )
protected boolean checkTestClasses;

/**
Expand Down