-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[go] Fix hermes inspector crash from vscode-expo (expo#23271)
# Why when vscode-expo sending the `Runtime.callFunctionOn` event, it will crash ios expo go. close ENG-9172 # How compared this on top of expo-go and expo-dev-client, both reaching the line `throw std::runtime_error("unknown object id " + objId);`. only expo-go will crash the app because the exception is not caught. this happens on the new expo-go, even the older sdks (that's why this pr includes to backporting changes). as the comment said, i still not figure out why the `std::runtime_error` is not caught by the `std::exception`. but the trick works # Test Plan ios expo go + sdk49 + vscode-expo debugging
- Loading branch information
Showing
4 changed files
with
13 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule react-native
updated
1 files
+4 −0 | packages/react-native/ReactCommon/hermes/inspector/Inspector.h |