Skip to content

v14.0.0.1 Revision

Compare
Choose a tag to compare
@mdebarros mdebarros released this 19 Oct 17:44
1a6940c

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880

  • fixes to collections/hub/golden_path/feature_tests/block_transfers
    • aligned liquidity and position calculations with central-ledger logic
    • cleaned up unnecessary requests (i.e. why have two requests to fetch settlement and position accounts when it can be done in one?)
  • re-factored [new sims] transfers, positions CGS Window1 tests (OTC-649, OTC-645) @ collections/hub/golden_path/settlement_cgs/newsetcgs
    • standardised naming convention
    • re-aligned position, settlement and interchange checks with central-ledger logic, and expanded on checks dynamically based on the transfer amounts (Tx1, Tx2, Tx3, Tx4, Tx5, Tx6) instead of using "hard-coded" values
    • consolidated separate GET /account test-case for settlement, and positions into a single test-case (i.e. only need one call to admin API to retrieve balances and do validation checks)
    • added new OPTIONAL env vars for:
      1. SETTLEMENT_CGS_TX_AMOUNT_1 (defaults: 15), SETTLEMENT_CGS_TX_AMOUNT_2 (defaults: 87.88), SETTLEMENT_CGS_TX_AMOUNT_3 (defaults: 158.36), SETTLEMENT_CGS_TX_AMOUNT_4 (defaults: 211.11), SETTLEMENT_CGS_TX_AMOUNT_5 (defaults: 14.05), SETTLEMENT_CGS_TX_AMOUNT_6 (defaults: 150) representing the transfer amounts for each Transaction. These correlate to Tx1...Tx6
      2. SETTLEMENT_RULE_INTERCHANGE_FEE (defaults: 0.006) which is the Interchange Fee % aused to calculate the aggregate Fee

fix(mojaloop/#2734): failures in daily cron job running GP tests - mojaloop/project#2734

  • added re-try logic to create interchange-fee settlements as part of CGS test-suite
  • bumped up RETRY_MAX_ATTEMPTS (10 to 20) & RETRY_MAX_WAIT_IN_MS (200 to 250) values to improve stability

What's Changed

  • feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation by @mdebarros in #84

Full Changelog: v14.0.0...v14.0.0-1