feat(mojaloop/#2881): add bulk transfer timeout tests #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collections/hub/other_tests/bulk_transfers/bulk-transfer-timeout-scenario.json
Outdated
Show resolved
Hide resolved
collections/hub/other_tests/bulk_transfers/bulk-transfer-timeout-scenario.json
Outdated
Show resolved
Hide resolved
collections/hub/other_tests/bulk_transfers/bulk-transfer-timeout-scenario.json
Outdated
Show resolved
Hide resolved
collections/hub/other_tests/bulk_transfers/bulk-transfer-timeout-scenario.json
Outdated
Show resolved
Hide resolved
|
Thanks Kevin @kleyow , looking good. just minor description changes.. Separately we need to discuss the behavior for the second scenario and create a follow-up issue for that.. : what is the expected behavior - should we log an error, should we send an error callback or patch notification or similar.. |
Co-authored-by: Sam <[email protected]>
|
@elnyry-sam-k done |
kleyow
changed the title
elnyry-sam-k
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2881): add bulk transfer timeout tests - mojaloop/project#2881
Added test for scenario - POST /bulkTransfers prepare request which has timed out. Assert both Payer and Payee receive PUT /bulkTransfers/{ID} callbacks detailing a COMPLETED bulkTransfer with individualTransfer errors for all transfers.
Added test for scenario - POST /bulkTransfers prepare request which has timed out and the Payee sends a late PUT /bulkTransfers/{ID} fulfilment request. Assert both Payer and Payee receive PUT /bulkTransfers/{ID} callbacks detailing a COMPLETED bulkTransfer with individualTransfer errors for all transfers. Positions don't change after late fulfilment.