fix: provisioning get settlement accountid #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 30, 2022 22:16
| @@ -367,7 +367,7 @@ | |||
| "requestVariables.quoteId = '{$function.generic.generateUUID}'", | |||
| "requestVariables.transactionId = '{$function.generic.generateUUID}'", | |||
| "", | |||
| "requestVariables.amount = -Number(environment.payerSettlementAccountBalance) - Number(environment.payerPositionBeforeTransfer) + 1000;", | |||
| "requestVariables.amount = -Number(environment.payerSettlementAccountBalance).toFixed(2) - Number(environment.payerPositionBeforeTransfer).toFixed(2) + 1000;", | |||
There was a problem hiding this comment.
the "2" here if it is the digits after the period, using two here maybe fine for now, but we'll need to get the scale specific to each currency based on the ISO 4217 standards for this to be generic, isn't it?
There was a problem hiding this comment.
Agreed. But we need to expose a simple function to get the scale for a currency based on the ISO 4217 codes to use in scripts. There are many other places where we used "2". Need to modify TTK which takes time and can be a separate story.
There was a problem hiding this comment.
Ok. Please capture this separate story so that we don't miss it..
Approving PR.. Thanks!
|
Looks good, except for just one minor comment. Thanks! |
elnyry-sam-k
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.