fix: bulk tests #65
Merged
fix: bulk tests #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdebarros
commented
Feb 25, 2022
•
mdebarros
commented
- split up bulk positive test assertions from using JSON.stringify which will fail since ordering of JSON elements are not guaranteed
Added the following test-case scenarios for patch notifications: - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with COMMITTED after sending callback with RESERVED - mojaloop/project#2676 - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid fulfilment - mojaloop/project#2556
- invalid fsp-destination - placeholder for invalid fulfilment
- added bugfix test-case for "Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect/non-existent FSP-ID in the FSPIOP-Destination header #2697" - updated "patch_notification" feature test
…es into feat/patch-notification-test-scenarios
…es into feat/patch-notification-test-scenarios # Conflicts: # collections/hub/golden_path/feature_tests/patch_notifications/patch_notification.json
…es into feat/patch-notification-test-scenarios
…es into feat/patch-notification-test-scenarios
- split up bulk positive test assertions from using JSON.stringify which will fail since ordering of JSON elements are not guaranteed
mdebarros
changed the title
vijayg10
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.