fix(mojaloop/#2644): missing error-code for the transfer in the central-ledger db #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-ledger db - added payer_transfer_timeout.json test-case to feature_tests/transfer_negative_scenarios
kleyow
reviewed
Dec 9, 2022
| } | ||
| }, | ||
| { | ||
| "id": 9, |
There was a problem hiding this comment.
I know this wouldn't change the result but a delay of 2 seconds before this request is sent off adds certainty it is sent after the transfer times out.
There was a problem hiding this comment.
I don't think its necessary, as we only move to the balance checks after receiving the timeout callback, which means that all the positions are reset.
mdebarros
deleted the
fix/#2644-Missing-Error-code-for-the-transfer-in-the-Central-ledger-DB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#2644): missing error-code for the transfer in the central-ledger db - mojaloop/project#2644