fix: properly stop token refresh #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalinkrustev
requested review from
kirgene,
elnyry-sam-k,
lewisdaly,
bushjames,
kleyow and
mdebarros
as code owners
|
vijayg10
approved these changes
Sep 12, 2024
kleyow
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a situation where the
WSO2Auth.stop()method is called while the HTTP request is started but not yet finished. In this case it will restart the refresh cycle after the HTTP request is finished. This is unwanted behavior and additionally thestop()method is likely to be called in the case of "destroying" the WSO2Auth object, i.e. removing any external references to it, but the re-activated refresh will keep another reference within the timer, thus creating both a memory leak and rogue loop of endlessly refreshing the token, which is not used anywhere.