Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting Service: Add support for a simple routing mode #5

Merged
merged 11 commits into from
May 29, 2019
Merged

Quoting Service: Add support for a simple routing mode #5

merged 11 commits into from
May 29, 2019

Conversation

rmothilal
Copy link
Contributor

added simple routing mode and fixes for all tests
still one minor error in testing but will be fixed on quote refactor
updated server to handle and respond to errors as defined in Mojaloop spec
updated swagger to allow proper content-type
mojaloop/project#775

@rmothilal rmothilal requested a review from mdebarros May 29, 2019 17:35
@rmothilal rmothilal self-assigned this May 29, 2019
mdebarros
mdebarros previously approved these changes May 29, 2019
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if unit tests pass :D

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if unit tests pass :D

@rmothilal rmothilal merged commit ecbe511 into mojaloop:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants