feat (2352): update and standardise helm charts to use networking v1 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s email , removed redundant ingress templates in _helpers.tpl in charts that have mode to standardised ingress
tdaly61
requested review from
elnyry-sam-k,
rmothilal and
vijayg10
as code owners
|
@mdebarros : so I tested this on rancher k3s v1.24 and got identical results to k3s 1.21 |
tdaly61
changed the title
tdaly61
changed the title
tdaly61
changed the title
|
Re-crated this PR with a WiP branch on the Mojaloop Repo: #508 |
mdebarros
added a commit
that referenced
this pull request
Oct 19, 2022
…rking v1 (#508) feat(mojaloop/#2352): update and standardise helm charts to use networking v1 - mojaloop/project#2352 # Notes This PR is re-created from #506 which includes some fixes based on tests on k8s v1.24 # Changes: ## Update the Chart.yaml's and standardise all charts to helm v3 (API v2) - move any dependencies in the requirements.yaml to Charts.yaml - update the apiVersion for helm in all the Charts.yaml to 2.0 - add the common dependency to each chart that already has an ingress - remove all requirements.lock - update maintainers in chart.yaml to include [email protected] - bump chart versions ## Update the ingress and networking API to v1 and standardise where possible - if the chart has an ingress template the chart is not on the exclusion list (see below) => the ingress template is updated to be a clone of the bitnami example (a version of what already exists in the charts repo) - updates the values files for the new ingress settings - ensure the updated values files have the correct hostname for the ingress - checks for paths and extra paths correctly allowed for (i.e. all charts with extraPaths or extraHosts are on e - ensure the updated values files have the correct port number for the ingress - update config/default.json files for values.ingress.api.host or similar to use .Values.ingress.hostname - _helper.tpl's updated to use correct ingress APIs and remove redundant ingress logic and templates ## General Maintenance - Fixed lint issue - Removed forensicloggingsidecar, centralenduserregistry, kube-system from lint scripts since they are no longer supported - Updated Maintainers list for each chart ## Exclusion list of charts - i.e. these charts are not yet standardised to the new ingress modeled on the bitnami example : - Any existing ingress in these charts has been updated "in place" rather than replaced with the newer standardised bitnami modeled chart. - So the ingress.yaml, config/*json, _helper.tpls , values.yaml files etc have been updated to use the latest ingress but they remain non-standard compared to the rest of the code-base. - "finance-portal-settlement-management", - "finance-portal", - ~"thirdparty"~, - ~"thirdparty/chart-tp-api-svc"~, - ~"thirdparty/chart-consent-oracle"~, - ~"thirdparty/chart-auth-svc"~, - ~"mojaloop-simulator"~, - "keycloak", - "monitoring", - "monitoring/promfana", - "monitoring/elk", - "ml-testing-toolkit/chart-keycloak", - "ml-testing-toolkit/chart-backend", - "ml-testing-toolkit/chart-frontend", - "ml-testing-toolkit/chart-connection-manager-backend", - "ml-testing-toolkit/chart-connection-manager-frontend" Co-authored-by: tdaly61 <[email protected]> Co-authored-by: Sam <[email protected]>
vijayg10
added a commit
that referenced
this pull request
Nov 9, 2022
* feat(mojaloop/#2352): update and standardise helm charts to use networking v1 (#508) feat(mojaloop/#2352): update and standardise helm charts to use networking v1 - mojaloop/project#2352 # Notes This PR is re-created from #506 which includes some fixes based on tests on k8s v1.24 # Changes: ## Update the Chart.yaml's and standardise all charts to helm v3 (API v2) - move any dependencies in the requirements.yaml to Charts.yaml - update the apiVersion for helm in all the Charts.yaml to 2.0 - add the common dependency to each chart that already has an ingress - remove all requirements.lock - update maintainers in chart.yaml to include [email protected] - bump chart versions ## Update the ingress and networking API to v1 and standardise where possible - if the chart has an ingress template the chart is not on the exclusion list (see below) => the ingress template is updated to be a clone of the bitnami example (a version of what already exists in the charts repo) - updates the values files for the new ingress settings - ensure the updated values files have the correct hostname for the ingress - checks for paths and extra paths correctly allowed for (i.e. all charts with extraPaths or extraHosts are on e - ensure the updated values files have the correct port number for the ingress - update config/default.json files for values.ingress.api.host or similar to use .Values.ingress.hostname - _helper.tpl's updated to use correct ingress APIs and remove redundant ingress logic and templates ## General Maintenance - Fixed lint issue - Removed forensicloggingsidecar, centralenduserregistry, kube-system from lint scripts since they are no longer supported - Updated Maintainers list for each chart ## Exclusion list of charts - i.e. these charts are not yet standardised to the new ingress modeled on the bitnami example : - Any existing ingress in these charts has been updated "in place" rather than replaced with the newer standardised bitnami modeled chart. - So the ingress.yaml, config/*json, _helper.tpls , values.yaml files etc have been updated to use the latest ingress but they remain non-standard compared to the rest of the code-base. - "finance-portal-settlement-management", - "finance-portal", - ~"thirdparty"~, - ~"thirdparty/chart-tp-api-svc"~, - ~"thirdparty/chart-consent-oracle"~, - ~"thirdparty/chart-auth-svc"~, - ~"mojaloop-simulator"~, - "keycloak", - "monitoring", - "monitoring/promfana", - "monitoring/elk", - "ml-testing-toolkit/chart-keycloak", - "ml-testing-toolkit/chart-backend", - "ml-testing-toolkit/chart-frontend", - "ml-testing-toolkit/chart-connection-manager-backend", - "ml-testing-toolkit/chart-connection-manager-frontend" Co-authored-by: tdaly61 <[email protected]> Co-authored-by: Sam <[email protected]> * fix: als-admin api ingress service port (#511) - fixed als-admin api ingress service port from 4002 to 4001 - fixed formatting issues in for protocol_versions configs * fix(mojaloop/2995): update ttk-ui (#512) * chore: bumped up ttk-ui * chore: some change in appversion * fix: als-admin api ingress service port (#513) - fixed als api ingress service port fix from 4002/4001 to 80 - fixed formatting issues in for protocol_versions configs * chore: updated TTK and fixed some values * feat: added example backend chart for mojaloop (#517) feat: added example backend chart for mojaloop (#517) - mojaloop/project#3000 - updated mojaloop/values.yaml to include CONFIG section with YAML Anchor variables to make configurations easier - added example-mojaloop-backend for external backend dependencies to enable deployments on Kubernetes v1.22+ - updated shell helper scripts to include example-mojaloop-backend charts - updates CI config to add helm dependency repos and updated readme Co-authored-by: Miguel de Barros <[email protected]> * updates to chart appVersion description * fix: changed the default jws file path in sdk helm chart * fix: sdk helm values Co-authored-by: Miguel de Barros <[email protected]> Co-authored-by: tdaly61 <[email protected]> Co-authored-by: Sam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Update the Chart.yaml's and standardise all charts to helm v3 (API v2)
**Update the ingress and networking API to v1 and standardise where possible **
- update config/default.json files for values.ingress.api.host or similar to use .Values.ingress.hostname
- _helper.tpl's updated to use correct ingress APIs and remove redundant ingress logic and templates
Exclusion list of charts