Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11.0.0-PI12 #401

Merged
merged 19 commits into from
Nov 25, 2020
Merged

v11.0.0-PI12 #401

merged 19 commits into from
Nov 25, 2020

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Nov 18, 2020

Helm release changes

1. Maintenance updates

  1. GitHub issue: Helm Release v11.0.0: Updates to helm, Supporting QA, Fixes, Releases [old] project#1617
  2. FSP Interoperability API v1.1 Swagger file used from here: https://github.com/mojaloop/mojaloop-specification/tree/master/documents/v1.1-document-set
  3. For breaking changes, please review the "Breaking Changes" section below for for Mojaloop Helm v11.0.0
  4. Notes on simulators
    • Mojaloop-Simulator is enabled by default (six instances used).
    • Ensure that correct Postman Scripts are used if you wish to test against the Mojaloop-Simulators:
      - A single MojaSim collection is now available after reconciliation between two collections that existed previously.
      - Setup Mojaloop Hub : MojaloopHub_Setup
      - Setup Mojaloop Simulators for testing : MojaloopSims_Onboarding
      - Golden path tests: Golden_Path_Mojaloop
    • Legacy Simulators are still required and deployed by default; disabling this will cause issues since there is Account Lookup directory mocking functionality in this service. To run Golden path tests using the Legacy simulator:
      - Setup Mojaloop Hub, test FSPs : ML_OSS_Setup_LegacySim
      - Golden path tests: ML_OSS_Golden_Path_LegacySim
    • In order to run the Legacy Simulator postman collection or the Mojaloop-Simulator collection, their corresponding setup collection needs to be run first; this can be done without redeployment.
  5. Upgrades to all core and supporting services to support 11.0.0 release (see Application versions and release notes below)
  6. The current Golden Path collection expects
    quoting-service.config.simple_routing_mode_enabled to be set to false to get 100% pass-rate, if this flag is disabled, there will be failures in several quoting-service tests (7 expected failures). This command can be used to override the default config: helm install moja ./mojaloop/ -n demo --set quoting-service.config.simple_routing_mode_enabled=false
  7. Along with this configuration for on-us transfers is disabled on both default deployments and postman (ON_US_TRANSFERS_ENABLED on postman) collections.
  8. Moving to SemVer as the standard is now adopted. This will start with v11.0.0 and follow the general semantic versioning guidance after that.
  9. Updated Promfana chart with "Prometheus: v2.20.1; Grafana: v7.1.1"
  10. Updated EFK chart with “appVersion: "elasticsearch: 7.7.1; kibana: 7.7.1; apm-server: 7.7.1; fluentd-elasticsearch: 3.0.4"
  11. Charts now support deployments on Kubernetes v1.16.x onwards - Fix for issue Helm charts incompatible with Kubernetes v1.16.x #219
  12. Removed deprecated ingress-nginx chart (ingress-nginx chart from upstream instead of mojaloop/helm/kube-public/ingress-nginx #350). Please use Nginx official chart.
  13. Updated official Helm repo URIs for stable & incubator dependencies and documentation:
  14. Updated innodb_flush_log_at_trx_commit to the value of 1 for MySQL servers to ensure ACID compliance (ref: https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_flush_log_at_trx_commit)
  15. Renamed Central-Event-Processor's (CEP) MongoDB instance dependency to: nameOverride: cep-mongodb. This will ensure that the CEP has its own MongoDB instance.
  16. Renamed Mojaloop-Self-Testing-Toolkit's (TTK) MongoDB instance dependency to: nameOverride: ttk-mongodb. This will ensure that the TTK has its own MongoDB instance.

2. New Features

  1. Along with changes from v10.4.0 related to the version v1.1 of the Mojaloop FSP Interoperability API, additional follow-up changes are implemented and a few fixes made. The changes are listed in the tracking issue of the specification and there is additional context offered here. Epic: Epic: ML FSPIOP API v1.1 changes [PI-10]  project#1333
  2. Added TTK CLI chart to ml-testing-toolkit (Added TTK CLI chart to ml-testing-toolkit #380).
  3. Added the option to pass a template as the rules.json (Added the option to pass a template as the rules.json #353) in quoting service
  4. Updates for bulk transfers support in MojaSims/Scheme-Adapter (Bulk transfers support in sdk-scheme-adapter (mojaloop-simulator) - Part 2 project#1386)
  5. Added charts for bulk-get-handler: Investigate and resolve issue with GET /bulkTransfers in Mojadev2 project#1496
  6. Package development versions (Package development versions #354)
  7. Update helm charts to support kubernetes deployments1.15 and later versions: Update Helm charts to support Kubernetes deployments 1.15 and later versions project#1463 (PR#349)
  8. Added TTK CLI chart to ml-testing-toolkit (Added TTK CLI chart to ml-testing-toolkit #380)
  9. Modified the testing toolkit CLI chart to enabled scheduling (Modified the testing toolkit CLI chart to enabled scheduling #381)

3. Bug Fixes

  1. Incorrect error behaviour on transfer fulfilment with future timestamp 1708
  2. ACCEPT header returned in the PUT from switch for the timeout scenario 1710
  3. Date header missing from the Switch signature in timeout scenario 1709
  4. Valid transactionRequests callback in SDK responding with error response 1647
  5. Support test currencies XXX, XTS in ml-api-adapter 1652

4. Application versions

Application versions that are supported for this update:

  1. ml-api-adapter: v10.5.0 -> v11.1.2
  2. central-ledger: v10.5.1 -> v11.3.1
  3. account-lookup-service: v10.4.2 -> v11.1.2
  4. quoting-service: v10.5.5 -> v11.1.4
  5. central-settlement: v10.5.0 (no change)
  6. central-event-processor: v10.5.0 (no change)
  7. bulk-api-adapter: v10.5.0 -> v11.0.2
  8. email-notifier: v9.5.0 (no change)
  9. als-oracle-pathfinder: v9.4.0 --> v10.2.0
  10. transaction-requests-service: v10.4.0 -> v11.1.2
  11. finance-portal-ui: v10.4.0 (no change)
  12. finance-portal-backend-service: v10.4.0 (no change)
  13. settlement-management: v8.8.2 (no change)
  14. operator-settlement: v9.2.1 (no change)
  15. event-sidecar: v9.5.1 (no change)
  16. event-stream-processor: v9.5.0-snapshot
  17. simulator: v10.5.3 -> v11.0.2
  18. mojaloop-simulator: v10.4.1 -> v11.2.1
  19. sdk-scheme-adapter: v10.5.0 -> v11.8.0
  20. ml-testing-toolkit: v10.4.1 -> v11.5.0
  21. ml-testing-toolkit-ui: v10.4.1 -> v11.5.0
  22. ml-testing-toolkit-cli: v11.3.0 (new)

5. Application release notes

  1. ml-api-adapter - https://github.com/mojaloop/ml-api-adapter/releases/tag/v11.1.2
  2. central-ledger - https://github.com/mojaloop/central-ledger/releases/tag/v11.3.1
  3. account-lookup-service - https://github.com/mojaloop/account-lookup-service/releases/tag/v11.1.2
  4. quoting-service - https://github.com/mojaloop/quoting-service/releases/tag/v11.1.4
  5. central-settlement- https://github.com/mojaloop/central-settlement/releases/tag/v10.5.0
  6. central-event-processor - https://github.com/mojaloop/central-event-processor/releases/tag/v10.5.0
  7. bulk-api-adapter - https://github.com/mojaloop/bulk-api-adapter/releases/tag/v11.0.2
  8. email-notifier - https://github.com/mojaloop/email-notifier/releases/tag/v9.5.0
  9. als-oracle-pathfinder - https://github.com/mojaloop/als-oracle-pathfinder/releases/tag/v10.2.0
  10. transaction-requests-service - https://github.com/mojaloop/transaction-requests-service/releases/tag/v11.1.2
  11. finance-portal-ui - https://github.com/mojaloop/finance-portal-ui/releases/tag/v10.4.0
  12. finance-portal-backend-service - https://github.com/mojaloop/finance-portal-backend-service/releases/tag/v10.4.0
  13. settlement-management - https://github.com/mojaloop/settlement-management/releases/tag/v8.8.2
  14. operator-settlement - https://github.com/mojaloop/operator-settlement/releases/tag/v9.2.1
  15. event-sidecar - https://github.com/mojaloop/event-sidecar/releases/tag/v9.5.1
  16. event-stream-processor - https://github.com/mojaloop/event-stream-processor/releases/v9.5.0-snapshot
  17. simulator - https://github.com/mojaloop/simulator/releases/tag/v11.0.2
  18. mojaloop-simulator - https://github.com/mojaloop/mojaloop-simulator/releases/tag/v11.2.1
  19. sdk-scheme-adapter - https://github.com/mojaloop/sdk-scheme-adapter/releases/tag/v11.8.0
  20. ml-testing-toolkit - https://github.com/mojaloop/ml-testing-toolkit/releases/tag/v11.5.0
  21. ml-testing-toolkit-ui - https://github.com/mojaloop/ml-testing-toolkit-ui/releases/tag/v11.5.0
  22. ml-testing-toolkit-cli - https://github.com/mojaloop/ml-testing-toolkit-ui/releases/tag/v11.3.0

6. Operational Chart versions

  • EFK: v7.1.0 -> v11.0.0
  • Promfana: v8.4.0 -> v11.0.0

7. Breaking changes

8. Known Issues

9. Contributors:


PR Dependencies

@mdebarros
Copy link
Member Author

mdebarros commented Nov 19, 2020

GoldenPath results for the following version: mojaloop/postman#188

┌─────────────────────────┬────────────────────┬────────────────────┐
│                         │           executed │             failed │
├─────────────────────────┼────────────────────┼────────────────────┤
│              iterations │                  1 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│                requests │                483 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│            test-scripts │                842 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│      prerequest-scripts │                755 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│              assertions │               1760 │                  0 │
├─────────────────────────┴────────────────────┴────────────────────┤
│ total run duration: 13m 47.6s                                     │
├───────────────────────────────────────────────────────────────────┤
│ total data received: 537.29KB (approx)                            │
├───────────────────────────────────────────────────────────────────┤
│ average response time: 250ms [min: 178ms, max: 3.6s, s.d.: 186ms] │
└───────────────────────────────────────────────────────────────────┘

@mdebarros mdebarros marked this pull request as ready for review November 23, 2020 09:03
elnyry-sam-k
elnyry-sam-k previously approved these changes Nov 23, 2020
@elnyry-sam-k
Copy link
Member

Deployed this on dev1 and it looks ok..

@mdebarros
Copy link
Member Author

mdebarros commented Nov 23, 2020

After merging @vijayg10's changes to TTK.

Post-Hook Install:

┌─────────────────────────┬────────────────────┬────────────────────┐
│                         │           executed │             failed │
├─────────────────────────┼────────────────────┼────────────────────┤
│              iterations │                  1 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│                requests │                482 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│            test-scripts │                842 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│      prerequest-scripts │                755 │                  0 │
├─────────────────────────┼────────────────────┼────────────────────┤
│              assertions │               1760 │                 12 │
├─────────────────────────┴────────────────────┴────────────────────┤
│ total run duration: 13m 48.6s                                     │
├───────────────────────────────────────────────────────────────────┤
│ total data received: 541.44KB (approx)                            │
├───────────────────────────────────────────────────────────────────┤
│ average response time: 252ms [min: 180ms, max: 3.7s, s.d.: 241ms] │
└───────────────────────────────────────────────────────────────────┘

GoldenPath:

┌─────────────────────────┬─────────────────────┬─────────────────────┐
│                         │            executed │              failed │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│              iterations │                   1 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│                requests │                 482 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│            test-scripts │                 842 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│      prerequest-scripts │                 755 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│              assertions │                1760 │                   0 │
├─────────────────────────┴─────────────────────┴─────────────────────┤
│ total run duration: 13m 41s                                         │
├─────────────────────────────────────────────────────────────────────┤
│ total data received: 538.62KB (approx)                              │
├─────────────────────────────────────────────────────────────────────┤
│ average response time: 236ms [min: 178ms, max: 1595ms, s.d.: 111ms] │
└─────────────────────────────────────────────────────────────────────┘

@mdebarros
Copy link
Member Author

mdebarros commented Nov 25, 2020

Post-hook install tests via TTK:

--------------------TEST CASES--------------------
Test Suite:Test run after deployment
Environment:DEV2
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 264                           │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 264                           │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 61                            │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 28                            │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Wed, 25 Nov 2020 10:32:58 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Wed, 25 Nov 2020 10:33:17 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 18647 ms                      │
└───────────────────┴───────────────────────────────┘
TTK-Assertion-Report-multi-2020-11-25T10:33:17.028Z.html was generated
Terminate with exit code 0
Done

GoldenPath Test results:

┌─────────────────────────┬─────────────────────┬─────────────────────┐
│                         │            executed │              failed │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│              iterations │                   1 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│                requests │                 497 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│            test-scripts │                 842 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│      prerequest-scripts │                 755 │                   0 │
├─────────────────────────┼─────────────────────┼─────────────────────┤
│              assertions │                1767 │                   0 │
├─────────────────────────┴─────────────────────┴─────────────────────┤
│ total run duration: 11m 11.7s                                       │
├─────────────────────────────────────────────────────────────────────┤
│ total data received: 540KB (approx)                                 │
├─────────────────────────────────────────────────────────────────────┤
│ average response time: 224ms [min: 170ms, max: 1240ms, s.d.: 111ms] │
└─────────────────────────────────────────────────────────────────────┘

@elnyry-sam-k
Copy link
Member

Great work, Miguel!

Thanks!

@mdebarros mdebarros merged commit 87373ca into mojaloop:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants