Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE - ONLY REVIEW] #1070: Upgrade to Helm v3 #285

Closed

Conversation

oderayi
Copy link
Collaborator

@oderayi oderayi commented Mar 5, 2020

  • Updated CircleCI config to use Helm v3
  • Updated chart versions to 9.3.0
  • Consolidated requirements.yml and Chart.yml
  • Updated apiVersion for Charts.yml to v2

@oderayi oderayi marked this pull request as ready for review March 6, 2020 10:01
@oderayi oderayi self-assigned this Mar 6, 2020
@elnyry-sam-k elnyry-sam-k changed the title #1070: Upgrade to Helm v3 [DO NOT MERGE - ONLY REVIEW] #1070: Upgrade to Helm v3 Mar 6, 2020
@bushjames
Copy link
Contributor

@elnyry what is the timeline for helm version upgrade? This is pretty significant to current users and I suspect they will want time to test it before it becomes a necessity.

@elnyry-sam-k
Copy link
Member

@bushjames Currently we're working on making the changes for Helm v3 then, we'll try things out on the dev environments first, to understand compatibility issues with current Helm version (v2) (Example, deploy v3 charts using v2 on cluster setup using v2, though there are no server changes needed for helm v3, etc).

The plan (Miguel, Steven were I discussed it this morning) is to have two separate repos moving forward, a new repo (incubation) for Helm v3 to identify its behavior and then publish it only after internal validations. However, the plan is to keep the current helm repo intact to support implementations and adopters still using Helm v2 though we may not actively make changes to it, just to support Users already using it (unless its critical security, etc. issues).

Once we have a consensus or a general agreement, we can then move over to Helm v3 and then deprecate the Helm v2 repo at that time.

@elnyry-sam-k
Copy link
Member

@oderayi was able to deploy this in AWS dev environments a couple of times with default values and were able to deploy it on our dev2 environment (mojadev2) with the values for dev2.

Below are the results of the Golden path and the results are promising (no issues so far).

However, we'll probably not be merging this and instead move this to a new repo to maintain versions for both helm 2 (for partners, community members who need it) and helm 3

image

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is still applicable, please pull the latest changes from the master branch and resolve merge conflicts.

Also, see my one suggested comment.

@@ -129,9 +129,9 @@ Expected output:

## Removing Deployments

`helm del --purge <release-name>`
`helm uninstall <release-name>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use helm del <release-name> <-- this will match the deployment guide changes for helm v3.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ oderayi
❌ Sam


Sam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mdebarros
Copy link
Member

This issue has been resolved, refer to #219 for more information.

@mdebarros mdebarros closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants