feat(mojaloop/#3498): alter message keys for prepare, fulfil and timeout #965
Conversation
| @@ -198,7 +198,9 @@ const prepare = async (error, messages) => { | |||
| Logger.isInfoEnabled && Logger.info(Util.breadcrumb(location, `positionTopic1--${actionLetter}7`)) | |||
| functionality = TransferEventType.POSITION | |||
| const eventDetail = { functionality, action } | |||
| await Kafka.proceed(Config.KAFKA_CONFIG, params, { consumerCommit, eventDetail, toDestination }) | |||
| // Key position prepare message with payer account id | |||
| const payerAccount = await Participant.getAccountByNameAndCurrency(payload.payerFsp, payload.amount.currency, Enum.Accounts.LedgerAccountType.POSITION) | |||
There was a problem hiding this comment.
For this particular case here(happy path), if we want to save a DB query, the participant account id is already fetched in saveTransferPrepared of facade. You can pass it down to access here. But as long as the query is cached, I don't think its a must. @mdebarros What do you suggest?
There was a problem hiding this comment.
Lets create a story for this. The reason I say that is because this in practice shouldn't be an issue as long as caching is enabled.
We should definitely look at such improvements going forward. A dedicated story may also give us the opportunities to reduce other similar duplicate queries.
There was a problem hiding this comment.
I've created a story to optimize duplicated queries for participant currency id with a clause to investigate other instances of duplicated queries (still updating the story, just a placeholder) mojaloop/project#3515
feat(mojaloop/#3498): alter message keys for prepare, fulfil and timeout - mojaloop/project#3498
central-services-sharedproceed to lib with simplified keying logicNOTIFICATIONmessages in transfers handler