test(mojaloop/#3819): harden fx prepare flow #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kleyow
requested review from
mdebarros,
elnyry-sam-k and
vijayg10
as code owners
|
coverage step failing.. |
@elnyry-sam-k Yes, this is only a part of several hardening stories for fx implementation branch. We are tackling coverage bit by bit. This PR covers only some of the unit tests for just the prepare portion of the fx prepare flow. |
vijayg10
approved these changes
Apr 10, 2024
elnyry-sam-k
pushed a commit
that referenced
this pull request
Dec 20, 2024
* feat: added db migration scripts for fx * feat(3574): update prepare-handler to deal with FX transfers (#988) * feat(3574): updated prepare handler for FX * feat(3574): added fxTransfer related tables; updated validator for FX * feat(3574): added fxTransfer related tables; updated validator for FX * feat(3574): comments/todos * feat(3574): added fx roleTypes; added content.context * feat(3574): added cyril; updated unit-tests * feat(3574): added FX endpoints to seeds (#989) * feat: implement changes in position handler for FX (#986) * chore: updated central service shared lib * feat: added some changes for fx flow * feat: added changes for position prepare handler * chore: refactor cyril functions * feat: position-commit working * feat: upgraded central shared * chore(snapshot): 17.4.0-snapshot.0 * chore(snapshot): 17.4.0-snapshot.1 * chore(snapshot): 17.4.0-snapshot.2 * chore(snapshot): 17.4.0-snapshot.3 * chore(snapshot): 17.4.0-snapshot.4 * chore(snapshot): 17.4.0-snapshot.5 * chore(snapshot): 17.4.0-snapshot.6 * chore(snapshot): 17.4.0-snapshot.7 * chore(snapshot): 17.4.0-snapshot.8 * fix: positions * fix: disable unit tests for snapshot * chore(snapshot): 17.4.0-snapshot.9 * chore: added docs * chore: updated doc * fix: normal fulfil * fix: normal flow * fix: updated fx diagram * chore: dep update * chore(snapshot): 17.4.0-snapshot.10 * feat(mojaloop/#3689): fx quotes changes (#995) * feat: add FX quotes endpointType and kafka topics * chore: upgrade cs-shared * chore: fix audit * chore(snapshot): 17.4.0-snapshot.12 * ci: disable unit tests and test coverage runs for snapshots * chore(snapshot): 17.4.0-snapshot.13 * fix: manual changes from upstream commits * chore(snapshot): 17.7.0-snapshot.0 * chore(mojaloop/#3820): fix current tests and merge in main (#1000) * fix: cluster performance testing issues (#996) * test: fix disconnect errors (#998) * chore(release): 17.6.1 [skip ci] * chore: fix current tests * boolean * chore: add endpoints to test data * fix endpoint import * chore: improve validator coverage * chore: move prepare tests into file to match src structure --------- Co-authored-by: Kalin Krustev <[email protected]> Co-authored-by: mojaloopci <[email protected]> * test(mojaloop/#3819): harden fx prepare flow (#1002) * chore: more coverage * coverage * test(mojaloop/#3819): prepare handler testing (#1004) * test(mojaloop/#3819): prepare handler testing * dep * audit * reconcile to one file due to producer bug #3067 * address comments * chore: standardise position prepare handler (#1005) * feat: added fx-position-prepare capability to batch handler * chore: reverted fx implementation in non batch mode * chore: added unit tests * chore: dep, audit and lint --------- Co-authored-by: Kevin Leyow <[email protected]> * feat(mojaloop/#3844): added corner cases impl. for FX; added unit-tests (#1006) * feat(mojaloop/#3844): added corner cases impl. for FX; added unit-tests * feat(mojaloop/#3844): added corner cases impl. for FX; added unit-tests * feat(mojaloop/#3844): added fxTransferErrorDuplicateCheck table; moved fxFulfilt tests in a separare file * feat(mojaloop/#3844): run tests with output * feat(mojaloop/#3844): fixed unit-test on ci env * feat(mojaloop/#3844): added unit-tests for FxFulfilService; moved duplicateCheckComparator logic to service * feat(mojaloop/#3844): reverted ci test-coverage * feat(mojaloop/#3844): added license * feat(mojaloop/#3844): moved checkErrorPayload to helpers * feat(mojaloop/#3844): moved checkErrorPayload to helpers * feat(mojaloop/#3844): updated from feat/fx-impl * fix: removed fx position prepare integration tests in non batch mode (#1010) * chore: fix int tests, lint and update deps (#1013) * chore: lint and update deps * int test * chore: removed unneeded kafkaHelper; excluded some files from test-coverage check (#1015) * feat(mojaloop/#3844): added integration tests for fxFulfil flow (#1011) * feat(mojaloop/#3844): added corner cases impl. for FX; added unit-tests * feat(mojaloop/#3844): added corner cases impl. for FX; added unit-tests * feat(mojaloop/#3844): added fxTransferErrorDuplicateCheck table; moved fxFulfilt tests in a separare file * feat(mojaloop/#3844): run tests with output * feat(mojaloop/#3844): fixed unit-test on ci env * feat(mojaloop/#3844): added unit-tests for FxFulfilService; moved duplicateCheckComparator logic to service * feat(mojaloop/#3844): reverted ci test-coverage * feat(mojaloop/#3844): added license * feat(mojaloop/#3844): moved checkErrorPayload to helpers * feat(mojaloop/#3844): moved checkErrorPayload to helpers * feat(mojaloop/#3844): updated from feat/fx-impl * feat(mojaloop/#3844): added integration tests for fxFulfil flow * feat(mojaloop/#3844): fixed producer.disconnect() in int-tests * feat(mojaloop/#3844): added test:int:transfers script * feat(mojaloop/#3844): added duplicateCheck int test * feat(mojaloop/#3844): small cleanup * feat(mojaloop/#3844): added duplicate and fulfilment check int-tests * feat(mojaloop/#3844): removed unneeded code * feat(mojaloop/#3844): added testConsumer.clearEvents() for int-tests * feat(mojaloop/#3844): skipped newly added int-test * feat(mojaloop/#3844): updated validateFulfilCondition * feat: unskip int-test feat: unskip int-test * feat(mojaloop/#3844): removed unneeded npm script --------- Co-authored-by: Kevin Leyow <[email protected]> * test: added transferFulfilReject.end() (#1027) * feat: fx fulfil position batching (#1019) * feat: implemented fx * fix: unit tests * fix: unit tests * chore: removed fx-fulfil in non batch mode * feat: refactored position fulfil handler for fx * chore: removed fx from non batch position fulfil * chore: removed fx references from non batch position handler * chore: simplified existing tests * chore: added unit tests * fix: prepare position fx * chore(mojaloop/#3819): update functional tests and move fulfil int test (#1009) * chore: update functional tests * version * snap * test * name * func * update * test-function * snap * changes * feat: implemented fx * fix: unit tests * fix: unit tests * chore: removed fx-fulfil in non batch mode * add back functions * feat: refactored position fulfil handler for fx * chore: removed fx from non batch position fulfil * chore: removed fx references from non batch position handler * chore: simplified existing tests * chore: added unit tests * fix: prepare position fx * publish messages to batch topic * update script * move fxfulfil tests to batch tests --------- Co-authored-by: Vijay <[email protected]> * chore: add integration tests for pos fulfil fx (#1030) * feat: added integration test for fulfil fx * chore: refined integration tests * feat(mojaloop/#3818): added sequence and ER diagrams for transfer/fxTransfer flows (#1029) * feat(mojaloop/#3818): added sequence and ER diagrams for transfer timeout cron * feat(mojaloop/#3818): added sequence diagram for FX timeout * feat(mojaloop/#3818): added sequence diagram for FX timeout * feat(mojaloop/#3818): added transfer state diagrams * feat(mojaloop/#3818): added transfer state diagrams * feat(mojaloop/#3818): added transfer state diagrams * feat(mojaloop/#3818): added transfer state diagrams * feat(mojaloop/#3818): added transfer state diagrams * feat(mojaloop/#3818): finalize FX timeout diagrams * feat(mojaloop/#3818): added fxTimeout tables * feat(mojaloop/#3903): update interal state on fx fulfil to RECEIVED_FULFIL_DEPENDENT (#1032) * feat(mojaloop/#3903): update interal state on fx fulfil to RECEIVED_FULFIL_DEPENDENT * file * test * chore: update harness (#1031) * feat(mojaloop/#3904): add position event timeout reserved batch handling (#1033) * chore: add integration test for batch * unit * reenable * chore: comments * cleanup function * remove * unskip * fix potential int test failures * reorder * fix replace * Update README.md * feat: implemented timeout handler for fx (#1036) * feat: added timeout handler implementation * fix: queries * fix: int tests * fix: issues * fix: fx timeout * chore: update central services shared * fix: cicd * fix: deps * fix: lint * fix: unit tests * chore: added unit tests * chore: added unit tests * Fix/test (#1039) * dep, audit * fix test * chore: dep update --------- Co-authored-by: Kevin Leyow <[email protected]> * feat: enable sending events directly to Kafka (#1037) * chore(snapshot): 17.7.0-snapshot.3 * feat(mojaloop/#3904): add position event fx timeout reserved batch handling (#1035) * chore: add integration test for batch * unit * reenable * chore: comments * feat: added timeout handler implementation * test * cleanup function * test * remove * reorder * fix potential int test failures * fix tests * fix: queries * unit tests * unskip * fix potential int test failures * reorder * fix replace * unit tests * fix: int tests * fix: issues * fix: fx timeout * chore: update central services shared * fix: cicd * fix: deps * fix: lint * fix: unit tests * chore: added unit tests * chore: added unit tests * pull,audit,dep * update tests * update position query logic * rename * add comment * detail --------- Co-authored-by: Vijay <[email protected]> * chore(snapshot): 17.7.0-snapshot.4 * audit fix and dep update * audit fix and dep update * chore(snapshot): 17.7.0-snapshot.5 * image scan * chore(snapshot): 17.7.0-snapshot.6 * image scan * chore(snapshot): 17.7.0-snapshot.7 * node version * chore(snapshot): 17.7.0-snapshot.8 * revert pipeline changes to get working snapshot * chore(snapshot): 17.7.0-snapshot.9 * fix typo * chore(snapshot): 17.7.0-snapshot.10 * fix command * chore(snapshot): 17.7.0-snapshot.11 * fix: remove trx.rollback() (#1051) * fix: produce followup messages in parallel (#1052) * chore(snapshot): 17.7.0-snapshot.12 * fix: #3932 participant currency validation for fx (#1041) * fix: validation * fix: unit tests * fix: int tests * fix: some tests * fix: tests * fix: lint * fix: integration tests * chore: added coverage * chore: lint * chore: re-enabled some integration tests * fix: avoid extra db call (#1055) * chore(snapshot): 17.7.0-snapshot.13 * chore(snapshot): 17.7.0-snapshot.14 * feat(csi-164): parameterize switch id (#1057) * fix: migration scripts * chore(snapshot): 17.7.0-snapshot.17 * fix: migration scripts * chore(snapshot): 17.7.0-snapshot.18 * chore(snapshot): 17.7.0-snapshot.19 * chore(snapshot): 17.7.0-snapshot.20 * feat: extend admin api to support proxy participants (#1043) * feat: extend admin api to support proxy participants * image revert * audit * changes * changes * add filter * update swagger * fix: allow isProxy * feat(mojaloop/csi-190): add new state and functionality to handle proxied transfers (#1059) * diff * update diagram * chore: happy path * chore: int tests * chore(snapshot): 17.8.0-snapshot.0 * update tests * chore: add error cases * test: coverage * tests * tests * fix test * update dep --------- Co-authored-by: Kalin Krustev <[email protected]> * feat(csi-22): add proxy lib to handlers (#1060) * feat(csi-22): add proxy lib to handlers * diff * add * int tests * fix hanging int tests * fixes? * unit fixes? * coverage * feat: refactor proxy cache integration * feat: restore default * feat: minor optimization * test: update coverage * test: remove try-catch * fix: fix disconnect error * feat: proxy cache update (#1061) * addressed comments --------- Co-authored-by: Steven Oderayi <[email protected]> * feat(mojaloop/#3998): proxy obligation tracking for position changes (#1064) * fix: consider HUB_ID when seeding the hub (#1073) * fix: fsp id validation (#1074) * fix: Cannot read properties of undefined * chore(snapshot): 17.8.0-snapshot.1 * fix: name validation * chore(snapshot): 17.8.0-snapshot.2 * fix: isProxy validation (#1075) * feat(csi-22): add prepare participant substitution (#1065) * unit tests * unit tests * int tests * stuff * some int tests * comments * pass object * messy but working * coverage * hanging int test? * fix int tests * clarify naming * comment * fixes? * dep update * feat: fulfil obligation tracking (#1063) * feat(csi-22): add proxy lib to handlers * diff * add * int tests * fix hanging int tests * fixes? * unit fixes? * coverage * feat: add zero adjustment for prepare position batch * feat: refactor proxy cache integration * feat: restore default * feat: minor optimization * test: update coverage * test: remove try-catch * fix: fix disconnect error * feat(prepare-position): add proxy substitution and zero adjustment logic * fix: remove uneeded async * feat: proxy cache update (#1061) * addressed comments * chore: refactor * test: add unit tests * chore: minor refactor * chore: lint * feat: revert prepare hadnler change, update test coverage * feat: update docker compose and default config for docker * chore: remove commented code * test: update test * test: update test * feat: added proxy check in fulfil handler * fix: derive fn * fix: checkSameCreditorDebtorProxy * unit tests * unit tests * int tests * fix: unit tests * chore: added unit tests for proxyCache deriveCurrencyId function * chore: added coverage * stuff * some int tests * comments * pass object * messy but working * coverage * hanging int test? * fix int tests * feat: refactor * clarify naming * comment * feat: added more test coverage * fixes? * dep update * fix: int tests * fix: disable tests around fspiop header validation in fulfil * fix: int tests * chore: disabled a fulfil test due to and issue in position handler * fix: int tests * chore: addressed pr comment * fix: lint * fix: integration tests --------- Co-authored-by: Kevin Leyow <[email protected]> Co-authored-by: Steven Oderayi <[email protected]> * chore(snapshot): 17.8.0-snapshot.3 * feat(mojaloop/#3885): add migrations for storing fxQuotes (#1076) * initial fxQuote migrations * changes * changes * remove * audit dep * chore(snapshot): 17.8.0-snapshot.4 * feat: impl fx abort (#1077) * feat: added abort batching * fix: tests * fix: bulk abort * chore: cleanup * chore: added int tests * feat: added fx_abort_validation * fix: positions * fix: lint * fix: unit tests * chore: add test coverage * fix: tests * chore: migration fixes (#1078) * chore: migration fixes * chore(snapshot): 17.8.0-snapshot.5 * field * chore(snapshot): 17.8.0-snapshot.6 * notnullable * chore(snapshot): 17.8.0-snapshot.7 * feat: position zero messages (#1079) * feat: initial commit * fix: int tests * fix: int tests * chore: skip coverage check for snapshots * chore(snapshot): 17.8.0-snapshot.8 * fix: proxy cluster * chore: dep update * chore(snapshot): 17.8.0-snapshot.9 * test: add unit tests for zero position change (#1081) --------- Co-authored-by: Steven Oderayi <[email protected]> * chore: add logging for admin api, proxy lookup, participant domain (#1080) * feat: initial commit * fix: int tests * fix: int tests * chore: skip coverage check for snapshots * chore(snapshot): 17.8.0-snapshot.8 * fix: proxy cluster * chore: dep update * chore(snapshot): 17.8.0-snapshot.9 * chore: add logging for admin api, proxy lookup, participant domain * fix tests * address comments * ignore --------- Co-authored-by: Vijay <[email protected]> * chore(snapshot): 17.8.0-snapshot.10 * fix: fx fulfil header validation (#1084) * fix: fx fulfil * chore(snapshot): 17.8.0-snapshot.10 * chore(snapshot): 17.8.0-snapshot.11 * chore(snapshot): 17.8.0-snapshot.12 * fix: fx fulfil proxy * chore(snapshot): 17.8.0-snapshot.13 * ci: make redis cluster default for integration tests (#1083) * fix: fx fulfil header validation2 (#1085) * fix: added missing fields in query * chore(snapshot): 17.8.0-snapshot.14 * fix: skip validation when payer and payee are represented by proxy (#1086) * fix: test * add unit tests * update saveTransferPrepared * chore: int tests * retry count --------- Co-authored-by: Vijay <[email protected]> * chore(snapshot): 17.8.0-snapshot.15 * feat(csi/551): add transfer state change for proxied fxTransfer (#1087) * feat(csi/551): add transfer state change for proxied fxTransfer * remove * add case * dep * unit tests * int tests * chore(snapshot): 17.8.0-snapshot.16 * fix: remove misleading commit and rollback (#1089) * fix: call commit and rollback * test: fix coverage * fix: call commit and rollback * fix: remove unnecessary commit and rollback * fix: remove unnecessary commit and rollback * fix: duplicate fx transfers (#1097) * fix: int tests * fix: int tests * fix: audit and lint fix * fix: spelling * chore: skipped an int test * chore(snapshot): 17.8.0-snapshot.17 * chore(snapshot): 17.8.0-snapshot.18 * chore(snapshot): 17.8.0-snapshot.19 * chore(snapshot): 17.8.0-snapshot.20 * fix: add duplication logic and test for fxTransfers * conversionState * alter int test for message key 0 * alter test --------- Co-authored-by: Kevin Leyow <[email protected]> * feat(csi-633): added externalParticipant model; added JSDocs; updated transfer/facade (#1099) * feat(csi-318): added externalParticipants table * refactor(csi-631): added calculateProxyObligation fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): improved logging in transfer facade * chore(csi-632): added migrations to create externalParticipant table * chore(csi-632): added migration to add externalParticipantId FK to fxTransferParticipant * chore(csi-632): added migration to add externalParticipantId FK to fxTransferParticipant * feat(csi-633): added externalParticipant model; added JSDocs; updated transfer/facade * feat(csi-633): added externalParticipantId field to fxTransferParticipant table * feat(csi-633): added externalParticipantId field to fxTransferParticipant table * Revert "feat(csi-633): added externalParticipant model; added JSDocs; updated transfer/facade" (#1100) Revert "feat(csi-633): added externalParticipant model; added JSDocs; updated…" This reverts commit eb54f67. * fix: get fx transfer not working (#1098) * fix: int tests * fix: int tests * fix: audit and lint fix * fix: spelling * chore: skipped an int test * chore(snapshot): 17.8.0-snapshot.17 * chore(snapshot): 17.8.0-snapshot.18 * chore(snapshot): 17.8.0-snapshot.19 * chore(snapshot): 17.8.0-snapshot.20 * fix: get fx transfers * fix: refactor * fix: fx fulfilment * fix: unit tests * fix: tests * fix: fx transfer extension (#1102) * fix: retify int tests (#1104) * fix: fix abort callback (#1106) fix: from argument in kafka notification for abort * Revert "fix: fix abort callback" (#1109) Revert "fix: fix abort callback (#1106)" This reverts commit b6e9e2b. * chore(snapshot): 17.8.0-snapshot.22 * fix: gp failure fixes for interscheme and fx changes (#1091) * fix: check participant.isActive in prepare * chore(snapshot): 17.8.0-snapshot.16 * chore(snapshot): 17.8.0-snapshot.17 * fix: check position account is active in prepare * chore(snapshot): 17.8.0-snapshot.18 * test: temporarily disable coverage for proxy * chore(snapshot): 17.8.0-snapshot.19 * chore(snapshot): 17.8.0-snapshot.20 * ci: temporarily disable int tests for snapshots * chore(snapshot): 17.8.0-snapshot.21 * fix: fix typos * refactor: reactor getFSPProxy * chore(snapshot): 17.8.0-snapshot.22 * doc: update comment * chore(snapshot): 17.8.0-snapshot.23 * fix(csi-603): fix getTransferParticipant query join * ci: re-enable integration tests for snapshots * chore(snapshot): 17.8.0-snapshot.24 * chore(snapshot): 17.8.0-snapshot.25 * fix: fix query * chore(snapshot): 17.8.0-snapshot.26 * refactor: refactor * refactor: refactor * fix(csi-610): fix hub responding with RESERVED instead of COMMITED for v1.1 reserved fulfil * chore(snapshot): 17.8.0-snapshot.27 --------- Co-authored-by: Vijay <[email protected]> * feat(csi/643): add fx-notify publishing on payer init fxTranfer success (#1105) * feat(csi/643): add fx-notify publishing on payer init fxTranfer success * loop * deps * tests * list * chore(snapshot): 17.8.0-snapshot.28 * fix: position changes (#1108) * fix: from argument in kafka notification for abort * fix: position changes * fix: to number * fix: position change in timeout * fix: related fxtransfer check * fix: unit tests * fix: timeout * chore: deps * fix fx-abort tests * fix fx-timeout tests * chore: added a comment * fix more tests * fix: invalid fulfilment * fix: unit test * chore(snapshot): 17.8.0-snapshot.28 * chore(snapshot): 17.8.0-snapshot.29 * fix: lint * chore(snapshot): 17.8.0-snapshot.30 --------- Co-authored-by: Kevin Leyow <[email protected]> * feat(csi-318): added externalParticipant table (#1092) * feat(csi-318): added externalParticipants table * refactor(csi-631): added calculateProxyObligation fn (#1093) * refactor(csi-631): added calculateProxyObligation fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): improved logging in transfer facade * chore(csi-632): added migrations to create externalParticipant table (#1094) * refactor(csi-631): added calculateProxyObligation fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): improved logging in transfer facade * chore(csi-632): added migrations to create externalParticipant table * chore(csi-632): added migration to add externalParticipantId FK to fxTransferParticipant * chore(csi-632): added migration to add externalParticipantId FK to fxTransferParticipant * feat(csi-633): added externalParticipant model; updated transfer/facade; added JSDocs; (#1101) * refactor(csi-631): added calculateProxyObligation fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): added forwardPrepare fn * refactor(csi-631): improved logging in transfer facade * chore(csi-632): added migrations to create externalParticipant table * chore(csi-632): added migration to add externalParticipantId FK to fxTransferParticipant * chore(csi-632): added migration to add externalParticipantId FK to fxTransferParticipant * feat(csi-633): added externalParticipant model; added JSDocs; updated transfer/facade * feat(csi-633): added externalParticipantId field to fxTransferParticipant table * feat(csi-633): added externalParticipantId field to fxTransferParticipant table * feat(csi-633): updated from feat/fx-impl * feat(csi-650): updated transferTimeout handler to take into account externalParticipant (#1107) * feat(csi-650): updated transferTimeout handler to take into account externalParticipant * feat(csi-650): fixed ep1.externalParticipantId field * feat(csi-650): used leftJoin for externalParticipant table * feat(csi-650): added externalPayeeName as source to timeout handler * feat(csi-650): updated fxTimeout logic to take into account externalParticipant info * feat(csi-650): code cleaning up * feat(csi-650): code cleaning up * feat(csi-651): updated fxAbort handling to use externalParticipant info (#1111) * feat(csi-650): updated transferTimeout handler to take into account externalParticipant * feat(csi-650): fixed ep1.externalParticipantId field * feat(csi-650): used leftJoin for externalParticipant table * feat(csi-650): added externalPayeeName as source to timeout handler * feat(csi-650): updated fxTimeout logic to take into account externalParticipant info * feat(csi-650): code cleaning up * feat(csi-650): code cleaning up * feat(csi-651): updated fxAbort handling to use externalParticipant info * feat(csi-651): updated fxValidation handling * feat(csi-651): fixed one leftJoin clause * feat(csi-651): updated getExternalParticipantIdByNameOrCreate * feat(csi-651): updated getExternalParticipantIdByNameOrCreate * feat(csi-651): added externalParticipantCached model * feat(csi-651): fixed prepare-internals tests * feat(csi-651): added more tests * feat(csi-651): reverted changes back to feat/fx-impl * feat(csi-651): reverted unneeded changes back to feat/fx-impl version * feat(csi-651): excluded some files from test coverage check * chore(snapshot): 17.8.0-snapshot.32 * chore(snapshot): 17.8.0-snapshot.33 * feat(csi-634): added mock-knex lib to mock mysql in unit-tests (#1113) * feat: add ULID support (#1114) * Fix code scanning alert no. 9: Missing regular expression anchor Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix: uuid/ulid regex * test: start using mojaloop/build orb (#1115) * fix: sonar security hot spots * Update src/shared/fspiopErrorFactory.js Co-authored-by: shashi165 <[email protected]> * chore: dep audit * chore: update licenses (#1138) * chore: update licenses * chore: update licenses * chore: deps * chore: address/remove todos * chore: update state diagram * chore: address comments * chore: address comments --------- Co-authored-by: Vijay <[email protected]> Co-authored-by: Eugen Klymniuk <[email protected]> Co-authored-by: vijayg10 <[email protected]> Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Kalin Krustev <[email protected]> Co-authored-by: mojaloopci <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: shashi165 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(mojaloop/#3819): harden fx prepare flow