fix(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…post /bulkTransfers fix(mojaloop/##2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796 - updated central-services-shared for updated enums - updated duplicate-prepare logic to produce NOTIFICATION event with correction action `BULK_PREPARE_DUPLICATE`
…-transaction-not-getting-callback-for-post-bulkTransfers # Conflicts:
…post /bulkTransfers feat(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796 - bumped central-services-shared dependency to working branch - added import aliases to package.json - updated Bulk Transfer Prepare logic to inject pre-calculated hash into comparator function
…post /bulkTransfers feat(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796 - Bumped central-services-shared latest release with supporting changes to v17.2.0 - Updated Bulk Transfer Prepare logic to inject pre-calculated hash into comparator function - Added sub-set of Unit Tests for Bulk Transfer Prepare Handler that are specific to this feature
mdebarros
requested review from
vgenev,
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vijayg10
as code owners
elnyry-sam-k
approved these changes
Aug 11, 2022
elnyry-sam-k
requested changes
Aug 11, 2022
Are you sure? https://github.com/mojaloop/central-ledger/pull/915/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R88 <-- it looks like |
elnyry-sam-k
previously approved these changes
Aug 11, 2022
elnyry-sam-k
approved these changes
Aug 11, 2022
mdebarros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796
BULK_PREPARE_DUPLICATEchore: maintenance
audit-resolve.json(i.e. replaced byaudit-ci.jsonc)