Skip to content

Commit

Permalink
fix(mojaloop/#2796): duplicate transaction not getting callback for p…
Browse files Browse the repository at this point in the history
…ost /bulkTransfers (not forked) (#915)

fix(mojaloop/#2796): duplicate transaction not getting callback for post /bulkTransfers - mojaloop/project#2796
- Updated central-services-shared for updated enums and comparator changes
- Updated duplicate-prepare logic to produce NOTIFICATION event with correction action `BULK_PREPARE_DUPLICATE`
- Updated Bulk Transfer Prepare logic to inject pre-calculated hash into comparator function
- Updated Bulk Transfer Prepare logic to inject pre-calculated hash into comparator function
- Added sub-set of Unit Tests for Bulk Transfer Prepare Handler that are specific to this feature (i.e. duplicate checks)

chore: maintenance
- Added import aliases to package.json
- added npm script audit:resolve
- removed deprecated `audit-resolve.json` (i.e. replaced by `audit-ci.jsonc`)
- audit fixes
  • Loading branch information
mdebarros authored Aug 11, 2022
1 parent b34f516 commit e520aa5
Show file tree
Hide file tree
Showing 8 changed files with 7,829 additions and 7,139 deletions.
2 changes: 1 addition & 1 deletion CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## @global-owner1 and @global-owner2 will be requested for
## review when someone opens a pull request.
#* @global-owner1 @global-owner2
* @vgenev @mdebarros @elnyry-sam-k @lewisdaly @oderayi @shashi165 @vijayg10
* @mdebarros @elnyry-sam-k @vijayg10 @kleyow
## Order is important; the last matching pattern takes the most
## precedence. When someone opens a pull request that only
## modifies JS files, only @js-owner and not the global
Expand Down
3 changes: 2 additions & 1 deletion audit-ci.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"GHSA-g64q-3vg8-8f93",
"GHSA-5854-jvxx-2cg9",
"GHSA-w5p7-h5w8-2hfq",
"GHSA-p9pc-299p-vxgp"
"GHSA-p9pc-299p-vxgp",
"GHSA-f825-f98c-gj3g"
]
}
156 changes: 0 additions & 156 deletions audit-resolve.json

This file was deleted.

Loading

0 comments on commit e520aa5

Please sign in to comment.