Skip to content

Commit

Permalink
fix: docker file using ci instead of install (#904)
Browse files Browse the repository at this point in the history
- aligned Dockerfile to use `npm ci`
- aligned ncurc file to yaml with appropriate comments
- updated dependencies
  • Loading branch information
mdebarros authored Jun 9, 2022
1 parent 9d68223 commit b01f079
Show file tree
Hide file tree
Showing 6 changed files with 562 additions and 162 deletions.
7 changes: 0 additions & 7 deletions .ncurc.json

This file was deleted.

9 changes: 9 additions & 0 deletions .ncurc.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
## Add a TODO comment indicating the reason for each rejected dependency upgrade added to this list, and what should be done to resolve it (i.e. handle it through a story, etc).
reject: [
# TODO: Tests fail when tape is upgraded.
"tape",
# TODO: New versions from 2.2.0 onwards introduce a newer incompatible version of the ILP-Packet that is not compatible with the Mojaloop Specification
"ilp-packet",
# TODO: v6+ (ref: https://github.com/sindresorhus/get-port/releases/tag/v6.0.0) is an ESM library and thus not compatible with CommonJS. Future story needed to resolve.
"get-port"
]
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ RUN apk add --no-cache -t build-dependencies make gcc g++ python3 libtool libres

COPY package.json package-lock.json* /opt/app/

RUN npm install
RUN npm ci

COPY src /opt/app/src
COPY config /opt/app/config
Expand Down
48 changes: 44 additions & 4 deletions audit-resolve.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
},
"1070030|widdershins>markdown-it": {
"decision": "ignore",
"madeAt": 1653393759905,
"expiresAt": 1655985751719
"madeAt": 1654684466912,
"expiresAt": 1657276460811
},
"1068155|@mojaloop/central-services-shared>shins>markdown-it>sanitize-html": {
"decision": "ignore",
Expand Down Expand Up @@ -72,8 +72,8 @@
},
"1070030|shins>markdown-it": {
"decision": "ignore",
"madeAt": 1653397119849,
"expiresAt": 1655989102215
"madeAt": 1654684412273,
"expiresAt": 1657276383700
},
"1068310|@mojaloop/central-services-shared>widdershins>markdown-it>yargs>yargs-parser": {
"decision": "ignore",
Expand All @@ -89,6 +89,46 @@
"decision": "ignore",
"madeAt": 1653397123215,
"expiresAt": 1655989102215
},
"1070449|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs": {
"decision": "ignore",
"madeAt": 1654684408664,
"expiresAt": 1657276383700
},
"1070449|@mojaloop/event-sdk>grpc>protobufjs": {
"decision": "ignore",
"madeAt": 1654684408664,
"expiresAt": 1657276383700
},
"1070030|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>widdershins>markdown-it": {
"decision": "ignore",
"madeAt": 1654684412273,
"expiresAt": 1657276383700
},
"1068310|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>widdershins>markdown-it>yargs>yargs-parser": {
"decision": "ignore",
"madeAt": 1654684414498,
"expiresAt": 1657276383700
},
"1070030|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>markdown-it": {
"decision": "ignore",
"madeAt": 1654684466912,
"expiresAt": 1657276460811
},
"1068155|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1654684468290,
"expiresAt": 1657276460811
},
"1070260|@mojaloop/central-services-shared>@mojaloop/event-sdk>grpc>protobufjs>shins>markdown-it>sanitize-html": {
"decision": "ignore",
"madeAt": 1654684469471,
"expiresAt": 1657276460811
},
"1070412|ejs": {
"decision": "ignore",
"madeAt": 1654684471083,
"expiresAt": 1657276460811
}
},
"rules": {},
Expand Down
Loading

0 comments on commit b01f079

Please sign in to comment.