Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template for flint #52

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

Tlazypanda
Copy link
Contributor

@Tlazypanda Tlazypanda commented Jun 11, 2020

Fixes #51 Added pull request template in .github folder to ease the process of making pull requests and to follow guidelines.

@Tlazypanda Tlazypanda force-pushed the add_pull_request_template branch from 0a409fe to fd88b54 Compare June 11, 2020 16:15
@gmajan
Copy link
Member

gmajan commented Jun 14, 2020

Sneha, thank you for this. Can you please make sure that the contributor has to sign off? By adding their email contributors confirm that they comply with the DCO:
"Sign your message with Signed-off-by: Random J Developer [email protected] to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.)"
For more see here https://github.com/moja-global/About_moja_global/blob/master/Contributing/How-to-Contribute-Code.md

@Tlazypanda Tlazypanda force-pushed the add_pull_request_template branch from fd88b54 to eea8855 Compare June 14, 2020 21:36
@Tlazypanda
Copy link
Contributor Author

Hey @gmajan I have updated the pull request ✌️

@Patamap Patamap requested a review from malfrancis June 15, 2020 00:02
@Patamap Patamap added Enhancement New feature request or improvement or optimization. Feedback This need feedback to make progress on it (e.g. spec data for a feature, repro steps for a bug). P1 Needs immediate attention. labels Jun 15, 2020
Copy link
Contributor Author

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gmajan Yeah the --signoff command works, there is even a shorthand for it just -s so the command will be basically like git commit -s -m "my first commit" or git commit --signoff -m "my first commit" You can find more information here https://github.com/git/git/blob/b2c150d3aa82f6583b9aadfecc5f8fa1c74aca09/Documentation/git-commit.txt#L154-L161

We can add this one too but I felt the other one might be a tad bit more convenient for developers 😅 Your call ✌️

@gmajan
Copy link
Member

gmajan commented Jun 16, 2020

Great. I am with you. Sorry for my ignorance and thank you for the link. Can we turn back the suggestion and then I will merge.
thx

@Tlazypanda
Copy link
Contributor Author

@gmajan please always share your feedback, it always helps to figure out in-case I missed something out or if there is a better way to solve a problem ✌️ This is the way we will learn and grow together 🎉 :octocat:

@Tlazypanda Tlazypanda force-pushed the add_pull_request_template branch from 51c4567 to eea8855 Compare June 16, 2020 12:45
@Tlazypanda
Copy link
Contributor Author

@gmajan Updated pull request 🎉

@gmajan gmajan merged commit e9c71b2 into moja-global:develop Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature request or improvement or optimization. Feedback This need feedback to make progress on it (e.g. spec data for a feature, repro steps for a bug). P1 Needs immediate attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants