Dashboard settings form QOL improvements

[zahid47]

addresses #49

shortBio is marked as optional in the Prisma schema, so the initial value is null which doesn't match with the type CurrentUser. So I'm setting it as an empty string if it is null. Not sure if it is the best approach, but any advice is appreciated!

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @moinulmoin on Vercel.

@moinulmoin first needs to authorize it.

[moinulmoin]

Thanks for the PR. I will check soon

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
chadnext	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2023 2:43pm

[moinulmoin]

Suggested change

	shortBio: z
	.string({
	required_error: "Please type a short bio.",
	})
	.string()
	.max(150, {
	message: "Short bio must be at most 150 characters.",
	})
	.min(10, {
	message: "Short bio must be at least 10 characters.",
	}),
	})
	.or(z.literal("")),
	shortBio: z
	.string()
	.max(150, {
	message: "Short bio must be at most 150 characters.",
	})
	.min(10, {
	message: "Short bio must be at least 10 characters.",
	})
	.optional(),

[moinulmoin]

Suggested change

	shortBio: currentUser.shortBio || "",
	shortBio: currentUser.shortBio,

[moinulmoin]

Suggested change

	<div className="mt-10 flex">
	<div className="mt-10">

[moinulmoin]

Suggested change

	<div className="flex">
	<div>

[moinulmoin]

All good. just need a few changes and then ready to merge. Thanks

[zahid47]

you can just call optinal method at the end to make it optional. take a look here

https://zod.dev/?id=optionals

This was my first intuition as well. But it doesn't work if you type something in the short bio field and then remove it. Because then it becomes an empty string (""), but it won't let you update your profile with bio as an empty string as min length is 10 chars.

And the flex class in the other file is to fix the alignment with "cancel" button. During loading state the alignment gets messed up and causes layout shift because of the loading icon

[moinulmoin]

And the flex class in the other file is to fix the alignment with "cancel" button. During loading state the alignment gets messed up and causes layout shift because of the loading icon

Hey,

you can just call optinal method at the end to make it optional. take a look here
https://zod.dev/?id=optionals

This was my first intuition as well. But it doesn't work if you type something in the short bio field and then remove it. Because then it becomes an empty string (""), but it won't let you update your profile with bio as an empty string as min length is 10 chars.

And the flex class in the other file is to fix the alignment with "cancel" button. During loading state the alignment gets messed up and causes layout shift because of the loading icon

Hey, seems you are right, I removed the min and max and I noticed font flickering issue while checking the buttons layout shift. I added few adjustments. thanks.