Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX(github/email): fix github oauth scope & callback handler #201

Merged
merged 2 commits into from
Apr 24, 2024
Merged

🐛 FIX(github/email): fix github oauth scope & callback handler #201

merged 2 commits into from
Apr 24, 2024

Conversation

ahmedrowaihi
Copy link
Contributor

I believe this was missed

Copy link

vercel bot commented Mar 18, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @moinulmoin on Vercel.

@moinulmoin first needs to authorize it.

@ahmedrowaihi
Copy link
Contributor Author

hey @moinulmoin
I guarantee a blind merge for this :')

@moinulmoin
Copy link
Owner

If you hadn't mixed it with irrelevant changes, I would have been happy to merge. Thanks for the PR though.

@moinulmoin moinulmoin closed this Apr 23, 2024
@ahmedrowaihi
Copy link
Contributor Author

@moinulmoin what was irrelevant ?
both are related to email : D

  • github sign in doesn't return email unless you define the scope
  • email was not imported so I added it

simply we can rename this PR if you think the name was more clear

@moinulmoin moinulmoin reopened this Apr 23, 2024
@moinulmoin
Copy link
Owner

@moinulmoin what was irrelevant ? both are related to email : D

  • github sign in doesn't return email unless you define the scope
  • email was not imported so I added it

simply we can rename this PR if you think the name was more clear

okay, please rename this pr and add the following changes, then we are good to merge.

@ahmedrowaihi ahmedrowaihi requested a review from moinulmoin April 23, 2024 11:31
@ahmedrowaihi ahmedrowaihi changed the title 🐛 FIX(server/mail): missing resend import 🐛 FIX(Email/Github): fix email imports & github callback Apr 23, 2024
@ahmedrowaihi ahmedrowaihi changed the title 🐛 FIX(Email/Github): fix email imports & github callback 🐛 FIX(github/email): fix github oauth scope & callback handler Apr 23, 2024
@ahmedrowaihi
Copy link
Contributor Author

ahmedrowaihi commented Apr 23, 2024

@moinulmoin is this better ? I also rebased the branch so it doesn't conflict with latest merges and keeps the commits clean

@moinulmoin
Copy link
Owner

Awesome bro, good job. Thank you so much for the PR

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chadnext ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:22am

@ahmedrowaihi
Copy link
Contributor Author

Awesome bro, good job. Thank you so much for the PR

All thanks to you!

@moinulmoin moinulmoin merged commit 6feefef into moinulmoin:main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants