Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try turning teleproto into a wrapper around chimney internal logic #338

Closed
wants to merge 48 commits into from
Closed

Try turning teleproto into a wrapper around chimney internal logic #338

wants to merge 48 commits into from

Conversation

urmaul
Copy link

@urmaul urmaul commented Jun 28, 2024 •
edited
Loading

Has the version number been increased?

  • Yes! (or not but it was intended to not increase it)

Related discussion here: scalalandio/chimney#573

urmaul and others added 30 commits April 18, 2024 13:51
@urmaul
Add Chimney dependency with a goal of turning teleproto into a wrappe…
9e84459 
…r around chimney
@urmaul
Comment out compileClassMapping
8873b71
@urmaul
Try deriving Transformer
337e359
@urmaul
trait Writer extends Transformer
8bcf6d0
@urmaul
Delete covariance from Writer
3a879dd
@urmaul
Add many printlns
5d2c0c5
@urmaul
Catch the error
7868dc3
@urmaul
Revert "Add many printlns"
3c4938c 
This reverts commit 5d2c0c5.
@urmaul
Relete covariance from Reader
273562f
@urmaul
Merge branch 'master' into delete_covariance
ac0544e
@urmaul
Delete migration
f8f106f
@urmaul
Bump version
74942e5
@urmaul
Merge remote-tracking branch 'origin/delete_covariance' into chimney_…
e2e3ab8 
…wrapper
@urmaul
uncomment generation
aa78885
@urmaul
fix test
44c5334
@urmaul
Another fix
c1ec2bb
@urmaul
Merge remote-tracking branch 'origin/delete_migration' into chimney_w…
cb75c94 
…rapper
@urmaul
Inject import
780e2d8
@urmaul
Derive enum readers explicitly
49a38a8
@urmaul
Use own marcos only for enums
86b11ad
@urmaul
Adjust MiMa filters
9a1e95f
@urmaul
Merge remote-tracking branch 'origin/delete_migration' into chimney_w…
51519bd 
…rapper
@urmaul
Adjust MiMa filters
8aa960c
@urmaul
Remove commented out code
c820ba0
@urmaul
Reader extends PartialTransformer
89676c7
@urmaul
add exclusion
9c2c48b
@urmaul
Add Reader.fromPartialTransformer
a8d1408
@urmaul
Bump chimney to 1.0.0
24b9beb
@urmaul
Merge branch 'master' into chimney_wrapper
466286e
@urmaul
Add some chimney conversions that dont help
fcefcd0
@urmaul
Copy link
Author

urmaul commented Oct 4, 2024

Finally managed to make a ProtobufEnumRule that can handle prefixes in enum variants.

@urmaul urmaul mentioned this pull request Oct 18, 2024
Closed
1 task
@urmaul
Copy link
Author

urmaul commented Oct 18, 2024

Status:

  • Fixed the implicit dependency cycle bug
  • Writers almost work as a drop-in replacement. The only missing feature it forward compatibility checks but this one is huge.
  • Started making code for readers.

@urmaul
Copy link
Author

urmaul commented Dec 3, 2024

Seems like migrating the app code to use chimney directly is much easier than mirgating teleproto. Closing this PR.

@urmaul urmaul closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxwbr lxwbr Awaiting requested review from lxwbr lxwbr will be requested when the pull request is marked ready for review lxwbr is a code owner

@HerrSchwarz HerrSchwarz Awaiting requested review from HerrSchwarz HerrSchwarz will be requested when the pull request is marked ready for review HerrSchwarz is a code owner

@saeltz saeltz Awaiting requested review from saeltz saeltz will be requested when the pull request is marked ready for review saeltz is a code owner

@JonasAckermann JonasAckermann Awaiting requested review from JonasAckermann JonasAckermann will be requested when the pull request is marked ready for review JonasAckermann is a code owner

@willbinzi willbinzi Awaiting requested review from willbinzi willbinzi will be requested when the pull request is marked ready for review willbinzi is a code owner

@houcros houcros Awaiting requested review from houcros houcros will be requested when the pull request is marked ready for review houcros is a code owner

@m-dobler m-dobler Awaiting requested review from m-dobler m-dobler will be requested when the pull request is marked ready for review m-dobler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@urmaul