Add CMake build support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogemimi
force-pushed
the
feature/cmake
branch
2 times, most recently
from
1bbebe9 to
a2429b0
Compare
mogemimi
force-pushed
the
feature/cmake
branch
2 times, most recently
from
8a1b87a to
71aacc3
Compare
mogemimi
force-pushed
the
feature/cmake
branch
from
71aacc3 to
aa33006
Compare
mogemimi
force-pushed
the
feature/cmake
branch
4 times, most recently
from
dd249bc to
f45c399
Compare
mogemimi
force-pushed
the
feature/cmake
branch
3 times, most recently
from
7e7784a to
128308d
Compare
|
I'm finally done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I (and we) would like to migrate from GYP (Generate Your Projects) to CMake build as a default Linux build system, for the following reasons:
Also I'm a CMake newbie 😥 , so could someone kindly help me review this pull request?