Removed unused system settings for "Rich-Text Editor" section

[Ruslan-Aleev]

What does it do?

Removed unused system settings for "Rich-Text Editor" section.

These settings are found only in the "System Settings", do not participate in the remaining code:

• editor_css_path
• editor_css_selectors

In the future, I will check the settings in other sections.

Related issue(s)/PR(s)

#14539 (comment)

[Mark-H]

I think the old tinymce package may use this?

That's obviously a poor reason to keep it in core, but if that's the case it's a good idea to make sure the package is updated to use a different setting first.

[Ruslan-Aleev]

I think the old tinymce package may use this?

@Mark-H I searched for this setting on github, there were no direct matches, only in MODX, as it seems to me.

[Ruslan-Aleev]

The old version of tinyMCE will not work with MODX 3, in any case. After all, the version of the editor after the release of MODX 3 will have to be updated for compatibility with MODX 3, and it would be disadvantageous to update the old version tinyMCE in any case.

[JoshuaLuckers]

I think the old tinymce package may use this?

That's obviously a poor reason to keep it in core, but if that's the case it's a good idea to make sure the package is updated to use a different setting first.

Seems like something that should be documented in the docs (Upgrading MODX).

[Mark-H]

I've opened an issue for TinyMCE and for the 3.0 upgrade documentation, but am wondering if perhaps we should make a special exception for these settings and don't actively remove them upon upgrade?

While that would leave an orphaned setting, that setting could potentially contain information that's still relevant for people's site.

On the other hand... that's a really old extra and I don't see any documentation explaining users how to use it, so we could also just go ahead with this and let Tiny figure it out. I'm a little conflicted, so opinions are welcome.

[JoshuaLuckers]

Maybe remove the settings only when the value equals the default install value?

[Mark-H]

I've decided it can't hurt to force tinymce to update for the first time in a few years while cleaning up the core.

[donShakespeare]

If no editor is the default editor for MODX there might be no planetary reason for keeping a specific strictly-related editor setting lying around in the MODX core.

Wise decision!