Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract getTags to own method #119

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Extract getTags to own method #119

wants to merge 2 commits into from

Commits on Aug 20, 2018

  1. Initial refactoring. Still got to work out how to deal with $total an… 

    …d $maxCnt
    @pbowyer
    pbowyer committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ff2edcc View commit details
    Browse the repository at this point in the history

  2. Add a new result class to hold tags, total and max count. Not the ret… 

    …urn signature that I want from getTags(), but not clear how to beter return everything from the two queries.

Two separate methods would be better, but there is overlap and the two are tied together. Propose and see how others want to refactor.
    @pbowyer
    pbowyer committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ead3b40 View commit details
    Browse the repository at this point in the history