Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chunkId may equal number 0 #2306

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: chunkId may equal number 0 #2306

merged 1 commit into from
Apr 9, 2024

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Apr 9, 2024

Description

fix: chunkId may equal number 0

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for module-federation-new ready!

Name Link
🔨 Latest commit 3bb0e09
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-new/deploys/6614ff7a50c3ce00086cccd8
😎 Deploy Preview https://deploy-preview-2306--module-federation-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 3bb0e09
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6614ff7a29676f0008b7b636
😎 Deploy Preview https://deploy-preview-2306--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1
Copy link
Member Author

2heal1 commented Apr 9, 2024

image

@zhoushaw zhoushaw merged commit 32eba3c into main Apr 9, 2024
14 checks passed
@zhoushaw zhoushaw deleted the fix/chunk-id-0 branch April 9, 2024 09:05
@2heal1 2heal1 mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants