-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance type capabilities #2185
Conversation
Would be helpful to know roughly what the dev server is doing. |
I forget to add the rfc link , here is : #2154 And more details will be added soon |
Got it. But to do so, IMO you don't need any of this code. As I said, using the bundler's proxy and a simple server would be enough and also bundler agnostic |
This is not for visit the type archive , is aims to help build analyzer get correct assets in prod environment |
@zhoushaw I think that removing the plugin owner from the review is an highly unprofessional behaviour.
Lots of comments I made have been ignored, but in the end this has been merged anyway, bringing into the plugin lots of crappy code full of I don't know if this is your usual way of work, but please stop ruining the work of people who try to keep high standards. |
@ilteoood I apologize for changing the reviewer's behavior, because Zhang Hang told me that the relevant problem has been fixed, and I saw that the relevant comments have been resolved,It seems that lint rules do not restrict some syntax content, is it possible to adjust lint to automatically handle some non-standard code? |
@2heal1 It seems that some of our errors have not been fixed, and I think we should fix this part of the optimization as soon as possible |
@ilteoood For code style, I think we can add lint to handle |
@ilteoood apologies for this. We will work to rectify this and appreciate your effort, input, and feedback. I can understand your frustration, but lets maintain a friendly correspondence in feedback. In the future we will be more careful regarding input and overwrites to other authored works. growing pains |
https://github.com/module-federation/universe/blob/main/CODE_OF_CONDUCT.md We will maintain the above code of conduct, If there are problems and feedback, we will accept the feedback with sincerity and patience and improve it, but we refuse to communicate in an unfriendly way |
I will give some feedback on the points mentioned in this pr:
The code style issues with the comments should all have been fixed,This part is best constrained and automated through prettierrc and lint rule sets |
Description
demo start steps:
You will see react-ts-host will auto fetch its remote types
And react_ts_nested_remote's dep react_ts_remote will be stored in
react_ts_nested_remote's/node_modules
which can support re-export remote .when update the
react_ts_nested_remote
, the host will auto fetch the latest types :Related Issue
#2154
Types of changes
Checklist