fix(sdk): wrong exportedInterface interface in createScriptNode #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! remoteEntry.js exports module with interface {get, init}, not {remoteName: {get, init}}, so we need exportedInterface here |
ScriptedAlchemy
approved these changes
Feb 7, 2024
|
@ScriptedAlchemy Hi, can you please help me, do I need to do something else to get this commit merged? |
|
@mababain please run |
mababain
force-pushed
the
fix/sdk-createScriptNode-bug
branch
from
a73115c to
c428437
Compare
mababain
changed the title
|
Good catch, thank you. I believe this happens when node is not commonjs-module output type. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes
Checklist