chore: move clear globalLoading logic to resetFederationGlobalInfo

module-federation · Nov 6, 2024 · a62ac79 · a62ac79
1 parent b4a4469
commit a62ac79
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/packages/node/src/utils/hot-reload.ts b/packages/node/src/utils/hot-reload.ts
@@ -153,9 +153,6 @@ export const performReload = async (
     gs.entryChunkCache.clear();
   }
 
-  Object.keys(helpers.global.globalLoading).forEach((key) => {
-    delete helpers.global.globalLoading[key];
-  });
   //@ts-ignore
   gs.__FEDERATION__.__INSTANCES__.map((i: any) => {
     //@ts-ignore

diff --git a/packages/runtime/src/global.ts b/packages/runtime/src/global.ts
@@ -112,6 +112,10 @@ export function resetFederationGlobalInfo(): void {
   globalThis.__FEDERATION__.moduleInfo = {};
   globalThis.__FEDERATION__.__SHARE__ = {};
   globalThis.__FEDERATION__.__MANIFEST_LOADING__ = {};
+
+  Object.keys(globalLoading).forEach((key) => {
+    delete globalLoading[key];
+  });
 }
 
 export function getGlobalFederationInstance(

diff --git a/packages/runtime/src/helpers.ts b/packages/runtime/src/helpers.ts
@@ -1,5 +1,4 @@
 import {
-  globalLoading,
   nativeGlobal,
   resetFederationGlobalInfo,
   getGlobalFederationInstance,
@@ -33,7 +32,6 @@ const ShareUtils: IShareUtils = {
 interface IGlobalUtils {
   Global: typeof Global;
   nativeGlobal: typeof global;
-  globalLoading: typeof globalLoading;
   resetFederationGlobalInfo: typeof resetFederationGlobalInfo;
   getGlobalFederationInstance: typeof getGlobalFederationInstance;
   setGlobalFederationInstance: typeof setGlobalFederationInstance;
@@ -55,7 +53,6 @@ interface IGlobalUtils {
 const GlobalUtils: IGlobalUtils = {
   Global,
   nativeGlobal,
-  globalLoading,
   resetFederationGlobalInfo,
   getGlobalFederationInstance,
   setGlobalFederationInstance,