Skip to content

Commit

Permalink
default component to 'div' if not specified
Browse files Browse the repository at this point in the history
  • Loading branch information
modosc committed Feb 2, 2018
1 parent 99c7685 commit 18b2b94
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 4 deletions.
4 changes: 3 additions & 1 deletion es/components.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion es/components.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion lib/components.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

2 comments on commit 18b2b94

@romanenko
Copy link

@romanenko romanenko commented on 18b2b94 Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, <Fragment> would be a better default: no extra elements created. But going this way would require React 16 for all users :(

@modosc
Copy link
Owner Author

@modosc modosc commented on 18b2b94 Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree - that's what [email protected] did but for some reason it blows up my work code and i haven't traced it down yet. so defaulting a <div> for now.

Please sign in to comment.