Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Autoreact plugin #3285

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Conversation

martinbndr
Copy link
Contributor

This PR adds a autoreact plugin.
Commands:
?startreact
?stopreact
Requested by clay#6272 on discord.

@StephenDaDev StephenDaDev added the plugin registry Request to be added into the plugin registry label Jul 4, 2023
@Taaku18 Taaku18 changed the base branch from master to development July 11, 2023 10:35
Copy link
Member

@StephenDaDev StephenDaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as designed. Looked through the code, all looks to be well. Icon is included, and fields are filled out. One small thing that I would say is you should probably disclose the 20 reaction limit in the help text for the command. I know it is sent in the activation message, but not in the help text. However, I would consider this to be an edge-case - I really doubt many will be affected by this-, so, consider it a nice to have and not a must have.

So will still recommend adding to registry on next update @Taaku18

Taaku18
Taaku18 previously approved these changes Jul 15, 2023
Copy link
Collaborator

@Taaku18 Taaku18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Taaku18 Taaku18 merged commit 5170035 into modmail-dev:development Jul 15, 2023
@Taaku18 Taaku18 added staged Staged for next version and removed pending review labels Jul 15, 2023
raidensakura pushed a commit to raidensakura/modmail that referenced this pull request Apr 10, 2024
* Added Autoreact plugin

* Update changelog

* black format (from a different pr's mistake)

---------

Co-authored-by: Taku <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin registry Request to be added into the plugin registry staged Staged for next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants