[modm-devices] Refactor data access #390
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
force-pushed
the
feature/modm-devices-data-access
branch
4 times, most recently
from
b17c8e9 to
ebf252a
Compare
salkinium
force-pushed
the
feature/modm-devices-data-access
branch
3 times, most recently
from
0e15d5d to
a5f0511
Compare
salkinium
force-pushed
the
feature/modm-devices-data-access
branch
from
a5f0511 to
1b92f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is too much data conversion code in modm's modules, some of which is duplicated.
This PR tries to move as much of this shared code to modm-devices, so that it can be used by everyone else too.
This is an exploration of this idea, so it may change significantly over time.
This PR depends on modm-io/modm-devices#35.
cc @rleh @chris-durand @strongly-typed @mikewolfram @dergraaf