Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#7252: Add type hints for base.py #7253

Merged
merged 2 commits into from
May 13, 2024
Merged

FEAT-#7252: Add type hints for base.py #7253

merged 2 commits into from
May 13, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 12, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add type hints for base.py #7252
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

anmyachev added 2 commits May 12, 2024 14:48
@anmyachev
FEAT-modin-project#7252: Add type hints for base.py
d460258 
Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev
fixes
4edd7ee 
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
anmyachev commented May 12, 2024
View reviewed changes
modin/pandas/base.py Outdated
Comment on lines 853 to 854
@abc.abstractmethod
def _reduce_dimension(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly note that the function must be defined in the descendants.

environment-dev.yml
@@ -50,6 +50,7 @@ dependencies:
- pytest-benchmark>=4.0.0
- pytest-cov>=4.0.0
- pytest-xdist>=3.2.0
- typing_extensions
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very lightweight dependency, only needed in a developer environment.

@anmyachev anmyachev marked this pull request as ready for review May 12, 2024 14:01
@YarShev YarShev merged commit ac3cc90 into modin-project:main May 13, 2024
38 checks passed
@anmyachev anmyachev deleted the type-hints branch May 13, 2024 09:44
@arunjose696 arunjose696 mentioned this pull request Jul 1, 2024
Closed
@korbit-ai korbit-ai bot mentioned this pull request Aug 13, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@korbit-ai korbit-ai bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type hints for base.py
2 participants
@anmyachev @YarShev