Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6687: Explicitly add users to CODEOWNERS #6688

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

devin-petersohn
Copy link
Collaborator

Resolves #6687

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Explicitly add individual team members to CODEOWNERS file #6687
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@devin-petersohn devin-petersohn requested a review from a team as a code owner October 30, 2023 20:13
CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Devin Petersohn <[email protected]>
RehanSD
RehanSD previously approved these changes Oct 30, 2023
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Devin Petersohn <[email protected]>
Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RehanSD RehanSD merged commit fab8bfd into modin-project:master Oct 30, 2023
5 checks passed
@RehanSD RehanSD deleted the issues/6687 branch October 30, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly add individual team members to CODEOWNERS file
3 participants