FIX-#6585: avoid FutureWarnings in rolling unless necessary
#6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
force-pushed
the
issue6585
branch
from
8e7af76 to
952f647
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anmyachev
force-pushed
the
issue6585
branch
2 times, most recently
from
90c3799 to
e38e846
Compare
…cessary Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
force-pushed
the
issue6585
branch
from
5f9837e to
e051936
Compare
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Sep 29, 2023
| df.rolling(**rolling_kwargs).quantile( | ||
| quantile=quantile, interpolation=interpolation, **kwargs |
There was a problem hiding this comment.
Deprecated kwarg name.
| @@ -24,8 +24,8 @@ def pytest_collection_modifyitems(items): | |||
| ): | |||
| for item in items: | |||
| if item.name in ( | |||
| "test_dataframe_dt_index[3s-both-DateCol-0]", | |||
| "test_dataframe_dt_index[3s-right-DateCol-0]", | |||
| "test_dataframe_dt_index[3s-both-DateCol-_NoDefault.no_default]", | |||
There was a problem hiding this comment.
To be align with the new value of axis for test_dataframe_dt_index test.
| @@ -34,7 +35,19 @@ | |||
| # have too many such instances. | |||
| # TODO(https://github.com/modin-project/modin/issues/3655): catch all instances | |||
| # of defaulting to pandas. | |||
| pytestmark = pytest.mark.filterwarnings(default_to_pandas_ignore_string) | |||
| pytestmark = [ | |||
There was a problem hiding this comment.
The same way as it done for test_groupby.py.
dchigarev
reviewed
Oct 2, 2023
| pytest.mark.filterwarnings( | ||
| "ignore:Support for axis=1 in DataFrame.rolling is deprecated:FutureWarning" | ||
| ), | ||
| # FIXME: these cases inconsistent between modin and pandas |
There was a problem hiding this comment.
in which way they're inconsistent, do we have an issue for that?
There was a problem hiding this comment.
Modin does not show this warning in cases where Pandas does. Not yet.
There was a problem hiding this comment.
@dchigarev let's merge, I will create issue later.
dchigarev
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -s.rollingfunc leads to gettingFutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.#6585docs/development/architecture.rstis up-to-date