Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#4348: use psycopg2-binary for testing and developing purpose #6573

Merged
merged 2 commits into from
Sep 20, 2023
Merged

TEST-#4348: use psycopg2-binary for testing and developing purpose #6573

merged 2 commits into from
Sep 20, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 18, 2023 •
edited
Loading

What do these changes do?

I guess we don't have to worry about how users install this dependency in production.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Error in psycopg2 installation during pip install -r requirements-dev.txt #4348
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review September 18, 2023 14:00
@anmyachev anmyachev requested a review from a team as a code owner September 18, 2023 14:00
@anmyachev anmyachev requested a review from YarShev September 18, 2023 14:02
vnlitvinov
vnlitvinov requested changes Sep 19, 2023
View reviewed changes
requirements-dev.txt
@@ -26,7 +26,7 @@ pandas-gbq>=0.15.0
tables>=3.7.0
# pymssql==2.2.8 broken: https://github.com/modin-project/modin/issues/6429
pymssql>=2.1.5,!=2.2.8
psycopg2>=2.9.3
psycopg2-binary>=2.9.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment here saying that psycopg devs recommend the other way of installation for production (as was discussed in original issue)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

vnlitvinov
vnlitvinov approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnlitvinov vnlitvinov merged commit a1a39a0 into modin-project:master Sep 20, 2023
33 checks passed
@anmyachev anmyachev deleted the isssue4348 branch September 20, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in psycopg2 installation during pip install -r requirements-dev.txt
2 participants
@anmyachev @vnlitvinov