Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#6569: use 'contextlib.nullcontext' instead of custom one #6570

Merged
merged 1 commit into from
Sep 18, 2023
Merged

REFACTOR-#6569: use 'contextlib.nullcontext' instead of custom one #6570

merged 1 commit into from
Sep 18, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 17, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: Use contextlib.nullcontext instead of custom one #6569
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review September 17, 2023 15:25
@anmyachev anmyachev requested a review from a team as a code owner September 17, 2023 15:25
@dchigarev dchigarev merged commit 860069d into modin-project:master Sep 18, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6569 branch September 18, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REFACTOR: Use contextlib.nullcontext instead of custom one
2 participants
@anmyachev @dchigarev