Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6553: fix 'read_csv' with 'iterator=True' #6554

Merged
merged 1 commit into from
Sep 13, 2023
Merged

FIX-#6553: fix 'read_csv' with 'iterator=True' #6554

merged 1 commit into from
Sep 13, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 12, 2023 •
edited
Loading

What do these changes do?

This case is not supported and should work correctly by defaulting to pandas.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: read_csv with iterator=True throws AttributeError #6553
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review September 12, 2023 19:53
@anmyachev anmyachev requested a review from a team as a code owner September 12, 2023 19:53
vnlitvinov
vnlitvinov approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vnlitvinov vnlitvinov merged commit abe20a5 into modin-project:master Sep 13, 2023
@anmyachev anmyachev deleted the issue6553 branch September 13, 2023 18:24
anmyachev added a commit to anmyachev/modin that referenced this pull request Oct 30, 2023
@anmyachev
FIX-modin-project#6553: fix 'read_csv' with 'iterator=True' (modin-pr…
1e53b08 
…oject#6554)

Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: read_csv with iterator=True throws AttributeError
2 participants
@anmyachev @vnlitvinov