REFACTOR-#4902: use isort #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
force-pushed
the
issue4902
branch
from
6a58edd to
6836309
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
anmyachev
force-pushed
the
issue4902
branch
2 times, most recently
from
d21387e to
45b1a1a
Compare
anmyachev
commented
Sep 12, 2023
| # NOTE: keep the black command here in sync with the pre-commit hook in | ||
| # /contributing/pre-commit | ||
| - run: black --check --diff modin/ asv_bench/benchmarks scripts/doc_checker.py | ||
| - run: isort . --check-only |
There was a problem hiding this comment.
I see no reason not to apply isort to all Python files in the project. black tool can also be applied to all Python files.
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
force-pushed
the
issue4902
branch
from
45b1a1a to
1fed21f
Compare
Signed-off-by: Anatoly Myachev <[email protected]>
dchigarev
previously approved these changes
Sep 13, 2023
vnlitvinov
requested changes
Sep 13, 2023
Signed-off-by: Anatoly Myachev <[email protected]>
vnlitvinov
previously approved these changes
Sep 15, 2023
dchigarev
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
isortworks as follows:isort .- automatically adjusts imports in all python files in the current directoryisort . --check-only- shows files that need to be fixedAll the changes are made automatically by
isort.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sadded andpassingdocs/development/architecture.rstis up-to-date