Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#4477: add tests for df.eval with scalar and groupby.transform call in the expr #6546

Merged
merged 1 commit into from
Sep 12, 2023
Merged

TEST-#4477: add tests for df.eval with scalar and groupby.transform call in the expr #6546

merged 1 commit into from
Sep 12, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 9, 2023 •
edited
Loading

What do these changes do?

Looks like #4477 is resolved, so I'll just add a test (the same for #5511 which I closed recently).

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves df.eval with a local variable in Modin results in AttributeError #4477
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review September 9, 2023 23:16
@anmyachev anmyachev requested a review from a team as a code owner September 9, 2023 23:16
vnlitvinov
vnlitvinov reviewed Sep 11, 2023
View reviewed changes
modin/pandas/test/dataframe/test_udf.py Outdated
Comment on lines 341 to 344
def test_eval_groupby_transform():
# see #5511 for details
df = pd.DataFrame({"num": range(1, 1001), "group": ["A"] * 500 + ["B"] * 500})
assert df.groupby("group")["num"].transform("min").unique().tolist() == [1, 501]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't about eval() with a scalar, now is it? 😜

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be enough to correct the name of the pull request or do you suggest splitting it?

@anmyachev
TEST-modin-project#4477: add tests for 'df.eval' with scalar and grou…
c076f4d 
…pby.transofm call in the expr

Signed-off-by: Anatoly Myachev <[email protected]>
@anmyachev anmyachev changed the title TEST-#4477: add test for 'df.eval' with scalar TEST-#4477: add tests for df.eval with scalar and groupby.transform call in the expr Sep 11, 2023
vnlitvinov
vnlitvinov approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vnlitvinov vnlitvinov merged commit 75e33fa into modin-project:master Sep 12, 2023
37 checks passed
@anmyachev anmyachev deleted the issue4477 branch September 12, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

df.eval with a local variable in Modin results in AttributeError
2 participants
@anmyachev @vnlitvinov