Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6446: Stop requiring modin-xgboost approval #6447

Merged

Conversation

mvashishtha
Copy link
Collaborator

What do these changes do?

Stop requiring modin-xgboost approval for xgboost code. Current @modin-project/modin-xgboost members don't know much more than other members of modin-core about the xgboost code.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves stop requiring modin-xgboost approval #6446
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@mvashishtha mvashishtha marked this pull request as ready for review August 3, 2023 00:25
@mvashishtha mvashishtha requested a review from a team as a code owner August 3, 2023 00:25
@YarShev
Copy link
Collaborator

YarShev commented Aug 3, 2023

@mvashishtha, please sign your commit message.

@mvashishtha mvashishtha force-pushed the 6446/fix/remove-modin-xgboost branch from 98eab61 to aa20b72 Compare August 16, 2023 17:05
@mvashishtha mvashishtha force-pushed the 6446/fix/remove-modin-xgboost branch from aa20b72 to 5cacaf3 Compare August 16, 2023 17:05
@mvashishtha
Copy link
Collaborator Author

@YarShev done

@YarShev YarShev merged commit 67d9ac5 into modin-project:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stop requiring modin-xgboost approval
2 participants