Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#5816: Implement '.split' method for axis partitions #5856
FEAT-#5816: Implement '.split' method for axis partitions #5856
Changes from 5 commits
c9aa819
7234d4f
609ad88
9316fbc
42b2250
d0c70e2
d23b4f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original
.split
method is already implemented in the manner of not extracting the metadata:modin/modin/core/dataframe/pandas/partitioning/partition.py
Lines 394 to 398 in cd7611c
So the full-axis implementation just follows the initial approach.
We don't want to extract metadata because:
split_row_partitions
are immediately replaced bynew_partitions
holding new metadata, meaning that the metadata ofsplit_row_partitions
is never accessed:modin/modin/core/dataframe/pandas/partitioning/partition_manager.py
Lines 1600 to 1608 in cd7611c
ncores ^ 2
), it's already not an easy task for ray to put into storage that big amount of futures at once, the situation becomes even worse when we ask to store the metadata futures as well (4 * (ncores ^ 2)
amount of futures at once). I've measured the case from [PERF] Slow sort_values in value_counts #5533 with and without the partition's metadata, and received a stable 9% speed-up (~ 0.12s) for the case without metadata.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
row_part
is now actually a row partition returning a list, meaning there's no need to wrap this into a list no moreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!