Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#5348: Instead of capping mypy, exclude 0.990. #5349

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

mvashishtha
Copy link
Collaborator

Signed-off-by: mvashishtha [email protected]

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves TEST: Remove mypy cap #5348
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@mvashishtha mvashishtha requested a review from a team as a code owner December 4, 2022 21:41
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@pyrito pyrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why it doesn't work? Maybe it's something worth mentioning to the mypy folks?

@dchigarev
Copy link
Collaborator

Do we know why it doesn't work? Maybe it's something worth mentioning to the mypy folks?

The issue was communicated to mypy in python/mypy#14027, they already fixed the issue and released a new 0.991 version with the fix. The 0.990 still doesn't work though, that's why we're excluding it.

@dchigarev dchigarev merged commit e4c5a47 into modin-project:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: Remove mypy cap
3 participants