REFACTOR-#5310: Remove some hasattr('columns') checks. #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anmyachev
reviewed
Dec 2, 2022
vnlitvinov
requested changes
Dec 5, 2022
mvashishtha
force-pushed
the
5310-remove-hasattr-columns-checks
branch
from
acd516a to
1c3be74
Compare
vnlitvinov
reviewed
Dec 6, 2022
| @@ -315,7 +315,7 @@ def broadcast_item( | |||
| index_values = obj.index[row_lookup] | |||
| if not index_values.equals(item.index): | |||
| axes_to_reindex["index"] = index_values | |||
| if need_columns_reindex and hasattr(item, "columns"): | |||
| if need_columns_reindex and isinstance(item, (pandas.DataFrame, DataFrame)): | |||
There was a problem hiding this comment.
this looks super-weird, should we really support both pandas and Modin versions of DataFrame here?
There was a problem hiding this comment.
We just need DataFrame. Done.
There was a problem hiding this comment.
It turns out we need both. Tests fail if we don't include both.
There was a problem hiding this comment.
I wonder if this should be a bug that we need both... cc @devin-petersohn
added 7 commits
December 6, 2022 12:33
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
mvashishtha
force-pushed
the
5310-remove-hasattr-columns-checks
branch
from
b73dc9b to
b9eae58
Compare
anmyachev
approved these changes
Dec 6, 2022
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mvashishtha [email protected]
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date