FIX-#3010: Update Ray version to 1.3 #3011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3011 +/- ##
===========================================
- Coverage 82.70% 70.58% -12.12%
===========================================
Files 144 144
Lines 14973 14946 -27
===========================================
- Hits 12383 10550 -1833
- Misses 2590 4396 +1806
Continue to review full report at Codecov.
|
|
|
|
|
Restarted |
|
This PR duplicates #2762 except some changes in the code and in the environment files. @devin-petersohn , do you plan to make respective changes in this PR? |
|
@YarShev this is not a duplicate of #2762. Ray 1.2 did not work and now that Ray 1.3 is out, we should update. We still have an issue with CI not checking PyPI wheels and the conda forge build will always lag. We should check with PyPI unless we plan to constantly keep https://github.com/conda-forge/ray-packages-feedstock up to date ourselves. So far, it is behind by 2 releases now. |
|
I see, that makes sense. |
YarShev
reviewed
Apr 28, 2021
| @@ -65,7 +65,7 @@ def _get_default(cls): | |||
| except ImportError: | |||
| pass | |||
| else: | |||
| if version.parse(ray.__version__) < version.parse("1.0.0"): | |||
| if version.parse(ray.__version__) < version.parse("1.3.0"): | |||
There was a problem hiding this comment.
Suggested change
| if version.parse(ray.__version__) < version.parse("1.3.0"): | |
| if version.parse(ray.__version__) < version.parse("1.0.0"): |
There was a problem hiding this comment.
We can't require ray version < 1.3.0 because we use environment-dev.yml, which installs 1.0.0, in CI.
|
Shouldn't we wait until conda-forge/ray-packages-feedstock#11 (and hence Ray 1.3.0 available in |
|
We should just use pypi because we shouldn't delay the upgrade. There are a lot of features on the latest Ray that we will want to take advantage of. |
cc @aregm This effectively means we're breaking the ability for end users to one-command-install latest Modin with OmniSci... as OmniSci is not present in pypi AFAIK. |
gshimansky
reviewed
May 5, 2021
| - run: python -m pytest -n 2 modin/pandas/test/test_concat.py --backend=${{ matrix.backend }} | ||
| - run: python -m pytest -n 2 modin/pandas/test/test_groupby.py --backend=${{ matrix.backend }} | ||
| - run: python -m pytest -n 2 modin/pandas/test/test_reshape.py --backend=${{ matrix.backend }} | ||
| - run: python -m pytest -n 2 modin/pandas/test/test_general.py --backend=${{ matrix.backend }} |
There was a problem hiding this comment.
Could you please make changes to tests in a separate PR as we usually required? Also, what is the reason to disable parallel tests?
There was a problem hiding this comment.
I saw some segmentation faults happened because of parallel test issues with the latest Ray. If it is necessary to keep the changes I will make a new PR, but for now it was meant to just test.
There was a problem hiding this comment.
I really hope that we can keep parallel tests. If new version of Ray cannot run in parallel, it would mean a regression from the current state.
There was a problem hiding this comment.
@gshimansky I agree
|
Ray bug that reproduces CI crashes ray-project/ray#15990 |
|
@gshimansky In this case, I suggest that we skip the failing tests in Ray until that bug can be fixed. As long as TeamCity can pass it will be fine. TeamCity is not currently passing, which is perhaps due to the xdist issue. |
If xdist cannot be enabled, we better just disable TeamCity CI because single process it will take forever to complete. TeamCity CI runs on big fat 48 core servers, but there are only a few of them. Parallelizing tasks by hosts is not an option, only parallelizing by processes running on the same host. |
|
@gshimansky based on the TeamCity logs do you think it is an xdist problem? |
It looks to me like the same crash bug in ray ray-project/ray#15990 that was just fixed in Ray master. The reason for it is that a list of crashed tests looks very similar to what we have in Github Actions CI: [09:20:25] [Step 5/8] =================================== FAILURES =================================== [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw46] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw46' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[rsub-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw47] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw47' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[sub-3.0-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw38] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw38' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[sub-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw41] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw41' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rsub-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw22] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw22' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rtruediv-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw43] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw43' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[rmod-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw33] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw33' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[sub-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw3] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw3' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rmod-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw18] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw18' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[truediv-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw10] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw10' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[truediv-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw15] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw15' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[rtruediv-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw13] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw13' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[mul-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw40] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw40' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[add-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw26] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw26' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[radd-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw28] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw28' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rmul-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw45] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw45' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[radd-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw2] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw2' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[mod-3.0-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw4] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw4' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rmod-3.0-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw31] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw31' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[add-columns-series_or_list]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw29] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw29' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[mul-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw0] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw0' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[mod-None-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw20] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw20' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[rmul-columns-series_or_list]' [09:20:25] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:25] [Step 5/8] [gw5] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw5' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-1-True-0]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw55] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw55' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rsub-3.0-check_different_index]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw49] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw49' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[add-3.0-check_different_index]' [09:20:25] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:25] [Step 5/8] [gw68] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw68' crashed while running 'modin/pandas/test/test_groupby.py::test_agg_func_None_rename[False-by_and_agg_dict2]' [09:20:25] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:25] [Step 5/8] [gw17] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw17' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-1-False-6]' [09:20:25] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:25] [Step 5/8] [gw59] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:25] [Step 5/8] worker 'gw59' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[radd-3.0-check_different_index]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw16] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw16' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[truediv-3.0-check_different_index]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw24] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw24' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[rfloordiv-columns-series_or_list]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw12] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw12' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rfloordiv-None-check_different_index]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw56] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw56' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions[floordiv-columns-series_or_list]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw63] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw63' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rtruediv-3.0-check_different_index]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw39] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw39' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-1-True-7]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw34] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw34' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-1-False-0]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw44] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw44' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[floordiv-3.0-check_different_index]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw37] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw37' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-1-True-6]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw64] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw64' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-1-False-7]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw42] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw42' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-2-True-6]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw54] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw54' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-2-False-6]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw32] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw32' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-2-True-0]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw61] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw61' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rfloordiv-3.0-check_different_index]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw19] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw19' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-2-False-0]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw60] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw60' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[rmul-3.0-check_different_index]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw48] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw48' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[mul-3.0-check_different_index]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw50] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw50' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-2-False-7]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw67] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw67' crashed while running 'modin/pandas/test/test_groupby.py::test_multi_column_groupby_different_partitions[False-2-True-7]' [09:20:26] [Step 5/8] __________________ modin/pandas/test/dataframe/test_binary.py __________________ [09:20:26] [Step 5/8] [gw73] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw73' crashed while running 'modin/pandas/test/dataframe/test_binary.py::test_math_functions_fill_value[floordiv-None-check_different_index]' [09:20:26] [Step 5/8] ______________________ modin/pandas/test/test_groupby.py _______________________ [09:20:26] [Step 5/8] [gw9] linux -- Python 3.8.10 /root/anaconda3/envs/modin/bin/python [09:20:26] [Step 5/8] worker 'gw9' crashed while running 'modin/pandas/test/test_groupby.py::test_agg_func_None_rename[True-by_and_agg_dict2]' |
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
Signed-off-by: Devin Petersohn <[email protected]>
|
Hey, just saw this linked from conda-forge/ray-packages-feedstock#11 which was auto-closed after @vnlitvinov managed to merge conda-forge/ray-packages-feedstock#8. Do you still need 1.3 specifically, or is going to 1.4 also an option? |
Modin needs Ray 1.4 (1.2 and 1.3 have bugs preventing us from moving to them), but I still plan to make 1.3 a thing in conda-forge. |
|
Upgrading to Ray 1.4 via #3132 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Devin Petersohn [email protected]
What do these changes do?
flake8 modinblack --check modingit commit -s