-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#1144: Fix read_parquet
for working with HDFS
#2120
Conversation
2029127
to
c476ca7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
===========================================
- Coverage 82.90% 69.46% -13.45%
===========================================
Files 116 116
Lines 13013 13019 +6
===========================================
- Hits 10788 9043 -1745
- Misses 2225 3976 +1751
Continue to review full report at Codecov.
|
@devin-petersohn can you review this, please? |
elif ( | ||
isinstance(path, str) | ||
and "://" in path | ||
and not path.startswith(("http://", "https://")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is http:// or https:// handled by ParuqetFile
constructor? The documentation did not say: https://arrow.apache.org/docs/python/generated/pyarrow.parquet.ParquetFile.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. It was fixed. Now I try to handle hdfs://
beginning only.
c476ca7
to
d204bae
Compare
Signed-off-by: Alexey Prutskov <[email protected]>
d204bae
to
77150c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prutskov, LGTM!
hi , thanks ! Murat KOÇ |
Signed-off-by: Alexey Prutskov [email protected]
What do these changes do?
flake8 modin
black --check modin
git commit -s