-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#1285: Add sem
implementation for Series
and DataFrame
#2048
Conversation
62b03d9
to
3a55bfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 81.94% 81.96% +0.01%
==========================================
Files 79 79
Lines 9564 9579 +15
==========================================
+ Hits 7837 7851 +14
- Misses 1727 1728 +1
Continue to review full report at Codecov.
|
3a55bfb
to
0e58c4c
Compare
@@ -2180,6 +2180,59 @@ def is_dtype_instance_mapper(column, dtype): | |||
] | |||
return self.drop(columns=self.columns[indicate], inplace=False) | |||
|
|||
def sem( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation of the method seems to me identical for Series and Dataframe.
Can implementation be defined in backends/pandas/query_compiler
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is specific for Series
and DataFrame
. Because we treat Series
as DataFrame
in the backend, the implementation can't be defined in backends/pandas/query_compiler
.
ec9a67e
to
518c611
Compare
4eb08e2
to
c9d090e
Compare
…ataFrame` Signed-off-by: Igoshev, Yaroslav <[email protected]>
c9d090e
to
beb13ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @YarShev !
…ataFrame` (modin-project#2048) Signed-off-by: Igoshev, Yaroslav <[email protected]>
Signed-off-by: Igoshev, Yaroslav [email protected]
What do these changes do?
flake8 modin
black --check modin
git commit -s